Fix 'getaddrinfo failed' error #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abias
force-pushed
the
main
branch
8 times, most recently
from
a1d0411 to
622f930
Compare
Check server address and port for unix socket
Member
|
Hi @leozelion , many thanks for your pull request and sorry that it remained unhandled for so long. I just rebased your PR onto latest main to allow Github actions to check it again. Looking closer at your patch, I think that it was fine for the time when you submitted it, but comparing it to today's /cache/stores/redis/lib.php:new_redis() code, I think that it needs some further adjustments as Redis cluster support has landed in MDL-63128 in the meantime. Would you have some more time to have a look at the code and align it to the way how /cache/stores/redis/lib.php:new_redis() works nowadays? Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection to Redis that worked on unix socket caused error
php_network_getaddresses: getaddrinfo failed: Name or service not known.Need to check the server address and port, as done in /cache/stores/redis/lib.php:new_redis()