Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore anonymous class docblocks if they have a parent #171

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

andrewnicols
Copy link
Contributor

There's usually little need to document an anonymous class when it is part of another method.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (e92f166) to head (db84372).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #171   +/-   ##
=========================================
  Coverage     98.11%   98.11%           
- Complexity      947      949    +2     
=========================================
  Files            40       40           
  Lines          2807     2809    +2     
=========================================
+ Hits           2754     2756    +2     
  Misses           53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

There's usually little need to document an anonymous class when it is
part of another method.
Copy link
Member

@stronk7 stronk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Andrew, it looks perfect, hence merging.

@stronk7 stronk7 merged commit 85e9e0a into moodlehq:main Jun 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants