Update to current box version (phar packaging) #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current version (2.x) is really old and emitting some warnings with php >= 8.1. So, just move to current 4.x version. Simply change to its new incarnation (fork of the original) and tidy up a few parameters. Note that the phar still has a good number of limitations: - Not all checks work (phpcs, behat...). - Cannot post-install moodle-local_ci (vnu.jar) - ... But all those are pre-existing and this new version does not change that. Note that box requires PHP 8.1 to build the phar, but the phar works perfectly with PHP 7.4 (our min requirement). Fixes moodlehq#235
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
=========================================
Coverage 84.55% 84.55%
Complexity 688 688
=========================================
Files 74 74
Lines 2130 2130
=========================================
Hits 1801 1801
Misses 329 329 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
|
Self merging... towards a release soon... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version (2.x) is really old and emitting some warnings with php >= 8.1. So, just move to current 4.x version.
Simply change to its new incarnation (fork of the original) and tidy up a few parameters.
Note that the phar still has a good number of limitations:
But all those are pre-existing and this new version does not change that.
Note that box requires PHP 8.1 to build the phar, but the phar works perfectly with PHP 7.4 (our min requirement).
Fixes #235