Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update App config defaults #274

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

NoelDeMartin
Copy link
Contributor

I'm opening this PR as a draft because until v4.4.0 of the app is released, these defaults don't work with the moodlehq/moodleapp:latest-test image, which is the default (they only work with moodlehq/moodleapp:next-test). But we can get the review started so that once 4.4.0 is released, we can merge this.

moodle-docker has a similar issue, but given that we explicitly support different versions, I've implemented an interim solution in moodlehq/moodle-docker#281.

But for moodle-plugin-ci, I think it's fine just to support one version out of the box. And anyone can configure old versions if they want using other env variables (the documentation has also been updated).

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.25%. Comparing base (30f6347) to head (0f5aebe).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #274      +/-   ##
============================================
+ Coverage     88.23%   88.25%   +0.02%     
- Complexity      735      739       +4     
============================================
  Files            76       76              
  Lines          2270     2274       +4     
============================================
+ Hits           2003     2007       +4     
  Misses          267      267              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NoelDeMartin NoelDeMartin marked this pull request as ready for review July 1, 2024 06:43
Copy link
Member

@stronk7 stronk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NoelDeMartin ,

really, there is something with the relations between MOODLE_APP_PORT, MOODLE_APP_PROTOCOL and MOODLE_BEHAT_IONIC_WWWROOT that I'm unable to understand completely, but, hey, that doesn't matter much for the purposes of the PR.

So, as far as it's all passing, I'm ok. I imagine that 99% of people really only needs to enable MOODLE_APP and that's all.

Ciao :-)

@stronk7 stronk7 merged commit 6bf32bc into moodlehq:main Jul 2, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants