Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this PR as a draft because until v4.4.0 of the app is released, these defaults don't work with the
moodlehq/moodleapp:latest-test
image, which is the default (they only work withmoodlehq/moodleapp:next-test
). But we can get the review started so that once 4.4.0 is released, we can merge this.moodle-docker
has a similar issue, but given that we explicitly support different versions, I've implemented an interim solution in moodlehq/moodle-docker#281.But for
moodle-plugin-ci
, I think it's fine just to support one version out of the box. And anyone can configure old versions if they want using other env variables (the documentation has also been updated).