Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #297 #301

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Issue #297 #301

wants to merge 1 commit into from

Conversation

ewallah
Copy link

@ewallah ewallah commented May 3, 2024

Grunt job is not ignoring hidden directories #297

Grunt job is not ignoring hidden directories moodlehq#297
@stronk7 stronk7 self-requested a review June 12, 2024 09:39
@stronk7
Copy link
Member

stronk7 commented Jun 12, 2024

Hi @ewallah ,

it seems that there are a few coding-style little changes to apply, plus unit tests are failing with your patch.

Is it ok if I amend your branch to make it CI compliant? Other than that, I think that the approach is correct and we can skip dot files without problem (at very least for grunt purposes).

@stronk7
Copy link
Member

stronk7 commented Jun 12, 2024

Oh, @ewallah,

I just was adding here a test and confirmed that FilesystemIterator::SKIP_DOTS does not skip all dot (hidden) files (.something.txt, .git, ...) but, exclusively, the "." and ".." directories. Hidden files and folders continue being returned by the iterator.

So, this doesn't seem to be enough to achieve what was desired (skip hidden dirs).

@stronk7 stronk7 added the question Further information is requested label Jun 12, 2024
@ewallah
Copy link
Author

ewallah commented Jun 13, 2024

Weird, since I added the SKIP_DOTS, I do not see any permission errors any more.

Feel free to add/change whatever is necessary!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants