Exit on error when something was wrong executing the command #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When something abnormal happens (wrong configuration, missing stuff, connectivity problems, etc., the phpcs execution can end with error. But, if max-warnings is enabled (>=0), then the count of errors and warnings (that is always 0 on error) gets precedence, hiding the real exit status. Hence it passes, when really it was not executed. Now we detect those abnormal situations and exit with error when something in the execution goes wrong. Covered with tests, checking all the possible max-warnings combinations.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #304 +/- ##
============================================
+ Coverage 88.22% 88.23% +0.01%
- Complexity 734 735 +1
============================================
Files 76 76
Lines 2267 2269 +2
============================================
+ Hits 2000 2002 +2
Misses 267 267 ☔ View full report in Codecov by Sentry. |
To avoid some NodeJS 16 warnings.
|
PS: Also, added a tiny 2nd commit that updates one GH Action to newer version that doesn't emit NodeJS 16 deprecation warnings. |
kabalin
approved these changes
Jun 3, 2024
|
tata, RK! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When something abnormal happens (wrong configuration, missing stuff, connectivity problems, etc., the phpcs execution can end with error.
But, if max-warnings is enabled (>=0), then the count of errors and warnings (that is always 0 on error) gets precedence, hiding the real exit status. Hence it passes, when really it was not executed.
Now we detect those abnormal situations and exit with error when something in the execution goes wrong.
Covered with tests, checking all the possible max-warnings combinations.