MOBILE-4532 quiz: Update behat tests #3955
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoelDeMartin
suggested changes
Mar 6, 2024
There was a problem hiding this comment.
I've found some things to improve, but overall the changes are good to go.
However, the CI won't pass until MDL-68806 is integrated in core, so we can't merge this until then. Once we resolve the changes I suggested, I can approve this and then we'll be able to merge it as soon as the core issue is integrated.
MDL-68806 adds the new "Submitted" quiz attempt state, which means that once an attempt is submitted, grades will not be available until the ad-hoc tasks have run.
marxjohnson
force-pushed
the
MOBILE-4532_main
branch
from
c167669
to
11314ff
Compare
|
Thanks for the pointers @NoelDeMartin, and for providing that updated snapshot. I have pushed an updated branch with those changes. |
NoelDeMartin
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Thanks @marxjohnson, I think this could be merged now but as I mentioned we need to wait until MDL-68806 is integrated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MDL-68806 adds the new "Submitted" quiz attempt state, which means that once an attempt is submitted, grades will not be available until the ad-hoc tasks have run.