Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Resolve decryption failures of password value in some browser #452

Merged
merged 5 commits into from
Nov 14, 2024
Merged

fix: Resolve decryption failures of password value in some browser #452

merged 5 commits into from
Nov 14, 2024

Conversation

Aquilao
Copy link
Contributor

@Aquilao Aquilao commented Nov 13, 2024

Proposed changes

Fixed the issue #89 that 360speed, QQ Browser and other Chinese browsers had errors in decrypting passwords and cookies

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit, build tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@coveralls
Copy link

coveralls commented Nov 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11828927950

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 42.273%
Changes Missing Coverage Covered Lines Changed/Added Lines %
browserdata/localstorage/localstorage.go 0 2 0.0%
browserdata/browserdata.go 0 4 0.0%
Totals Coverage Status
Change from base Build 11737197306: 0.0%
Covered Lines: 372
Relevant Lines: 880
💛 - Coveralls

@moonD4rk moonD4rk changed the title Fixed the issue #89 fix: Resolve decryption failures of password value in some browser Nov 13, 2024
@moonD4rk moonD4rk merged commit 57a123d into moonD4rk:dev Nov 14, 2024
6 checks passed
@moonD4rk
Copy link
Owner

LGTM😻

moonD4rk pushed a commit that referenced this pull request Nov 15, 2024
@Aquilao @moonD4rk
fix: Resolve decryption failures of password value in some browser (#452
b66ca7b 
)

* fix: skip chromium-based browser 'def' dir
* fix: fixed the issue that 360speed, QQ Browser and other Chinese browsers had errors in decrypting passwords and cookies
* misc: modify some log level
* fix: fix the wrong function

---------

Co-authored-by: Aquilao <Aquilao@outlook>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aquilao @coveralls @moonD4rk