Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to polkadot stable2409 #3031

Draft
wants to merge 39 commits into
base: master
Choose a base branch
from
Draft

Conversation

TarekkMA
Copy link
Contributor

@TarekkMA TarekkMA commented Nov 6, 2024

fixes #2994

What does it do?

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@TarekkMA TarekkMA marked this pull request as draft November 6, 2024 08:30
Copy link
Contributor

github-actions bot commented Nov 6, 2024

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2260 KB (no changes) ✅

Moonbeam runtime: 2224 KB (no changes) ✅

Moonriver runtime: 2232 KB (no changes) ✅

Compared to latest release (runtime-3300)

Moonbase runtime: 2260 KB (+232 KB compared to latest release) ⚠️

Moonbeam runtime: 2224 KB (+228 KB compared to latest release) ⚠️

Moonriver runtime: 2232 KB (+240 KB compared to latest release) ⚠️

@TarekkMA TarekkMA self-assigned this Nov 6, 2024
@TarekkMA TarekkMA linked an issue Nov 6, 2024 that may be closed by this pull request
@TarekkMA TarekkMA added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Nov 8, 2024
@TarekkMA TarekkMA added the breaking Needs to be mentioned in breaking changes label Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Coverage Report

@@                       Coverage Diff                       @@
##           master   moonbeam-polkadot-stable2409     +/-   ##
===============================================================
  Coverage   79.00%                         79.00%   0.00%     
  Files         303                            303             
+ Lines       88208                          88215      +7     
===============================================================
+ Hits        69685                          69687      +2     
+ Misses      18523                          18528      +5     
Files Changed Coverage
/node/cli/src/command.rs 17.69% (+0.08%) 🔼
/node/service/src/lib.rs 62.27% (+0.02%) 🔼
/node/service/src/rpc.rs 84.95% (-0.05%) 🔽
/pallets/moonbeam-foreign-assets/src/evm.rs 71.26% (+0.48%) 🔼
/runtime/common/src/weights/pallet_assets.rs 8.63% (-0.25%) 🔽

Coverage generated Tue Nov 19 15:01:18 UTC 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update polkadot-sdk from stable2407 to stable2409
1 participant