Enable benchmarks for pallet_xcm_benchmarks #3330

TarekkMA · 2025-06-26T18:14:27Z

⚠️ Breaking Changes ⚠️

Xcm instructions are now benchmarked and as a result the wights are now different than before

…pallet_xcm_benchmarks::generic`

coderabbitai · 2025-06-26T18:14:52Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

agent-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

TarekkMA · 2025-06-26T18:16:35Z

pallets/xcm-weight-trader/src/lib.rs

+			let weight = actual_weight.min(self.0);
+			let amount: u128 =
+				Self::compute_amount_to_charge(&weight, &location).unwrap_or(u128::MAX);
+			let amount_to_refund = initial_amount.saturating_sub(amount);
+			self.0 -= weight;
+			self.1 = Some(Asset {
+				fun: Fungibility::Fungible(amount_to_refund),
+				id: XcmAssetId(location.clone()),
+			});
+			log::trace!(
+				target: "xcm-weight-trader",
+				"refund_weight amount to refund: {:?}",
+				amount_to_refund
+			);
+			if amount > 0 {


Make the implementation the same as https://paritytech.github.io/polkadot-sdk/master/staging_xcm_builder/struct.UsingComponents.html

This resulted in fixing refund_surplus instruction benchmark test which was failing before.

Just replace amount by amount_to_refund lines 439 and 441.
The amount is not what we refund, it's what the user actually have to pay

runtime/common/src/apis.rs

runtime/moonbase/src/xcm_config.rs

runtime/moonriver/src/xcm_config.rs

runtime/common/src/apis.rs

github-actions · 2025-06-27T08:28:38Z

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2348 KB (-8 KB) ✅

Moonbeam runtime: 2500 KB (no changes) 🚨

Moonriver runtime: 2504 KB (+4 KB) 🚨

Compared to latest release (runtime-3800)

Moonbase runtime: 2348 KB (+304 KB compared to latest release) ⚠️

Moonbeam runtime: 2500 KB (+336 KB compared to latest release) 🚨

Moonriver runtime: 2504 KB (+340 KB compared to latest release) 🚨

benchmarking/xcm-weight-template.hbs

…le-benchmarks

github-actions · 2025-07-03T12:12:37Z

Moonbase Weight Difference Report

File	Extrinsic	Old	New	Change Percent

Moonriver Weight Difference Report

File	Extrinsic	Old	New	Change Percent

Moonbeam Weight Difference Report

File	Extrinsic	Old	New	Change Percent

librelois

About the very high cost for some XCM instructions, like WithdrawAsset:

I think it’s expected because these instructions can read an EVM contract and therefore add up to 24 KB of proof size—but in 99% of cases, that cost is too high for the user.

The ideal solution would be to have dynamic weight computation for XCM instructions that can read AccountCodesMetadata and charge accordingly.

If we can’t have dynamic weight computation, we could add a check in the pallet-ethereum-xcm to read AccountCodesMetadata and fail—without reading the actual bytecode—if the size exceeds a threshold. That threshold should be high enough to accommodate any legitimate ERC-20 (probably around 12 KB), so the cost will still be high for users.

If pallet-xcm benchmarks don’t support dynamic weight computation for XCM instructions, it may be a good reason to maintain a custom benchmarking pallet on our side.

Enable benchmarks for pallet_xcm_benchmarks and fix all issues with `…

7ce8a70

…pallet_xcm_benchmarks::generic`

TarekkMA commented Jun 26, 2025

View reviewed changes

runtime/common/src/apis.rs Outdated Show resolved Hide resolved

TarekkMA commented Jun 26, 2025

View reviewed changes

runtime/common/src/apis.rs Show resolved Hide resolved

TarekkMA commented Jun 26, 2025

View reviewed changes

runtime/common/src/apis.rs Show resolved Hide resolved

TarekkMA commented Jun 26, 2025

View reviewed changes

runtime/moonbase/src/xcm_config.rs Outdated Show resolved Hide resolved

RomarQ added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Jun 26, 2025

RomarQ reviewed Jun 26, 2025

View reviewed changes

runtime/moonriver/src/xcm_config.rs Outdated Show resolved Hide resolved

RomarQ reviewed Jun 26, 2025

View reviewed changes

runtime/common/src/apis.rs Outdated Show resolved Hide resolved

Cleanup AccountIdConverter

6af17ba

TarekkMA added the breaking Needs to be mentioned in breaking changes label Jun 27, 2025

TarekkMA added 3 commits June 27, 2025 11:41

Use MaxAssetsIntoHolding in worst_case_holding

30d3840

Increase worst_case_for_trader

6838bb8

Use new template for xcm weights

dc572f9

RomarQ reviewed Jun 27, 2025

View reviewed changes

benchmarking/xcm-weight-template.hbs Outdated Show resolved Hide resolved

RomarQ added the A8-mergeoncegreen Pull request is reviewed well. label Jun 30, 2025

TarekkMA added 3 commits July 3, 2025 13:29

Fix all issues with benchmarks

9f28066

use new benchmarks weights

477ff27

Merge remote-tracking branch 'origin/master' into tarekkma/xcm-fungib…

26b51e5

…le-benchmarks

TarekkMA and others added 4 commits July 3, 2025 16:41

Fix failing tests

4fb2a5d

clarify refund_weight impl var names

e9a2505

fix xcm-weight-trader

71ddf78

fix tests

67b8e1b

librelois requested changes Jul 8, 2025

View reviewed changes

TarekkMA added 2 commits July 11, 2025 12:06

fix tests

3f9d307

fmt

c4fb5d6

TarekkMA added 2 commits July 11, 2025 12:51

allow dead code inside generated xcm weights

22fb227

fmt

788477b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Enable benchmarks for pallet_xcm_benchmarks #3330

Enable benchmarks for pallet_xcm_benchmarks #3330

Uh oh!

TarekkMA commented Jun 26, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jun 26, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

TarekkMA Jun 26, 2025

Uh oh!

librelois Jul 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Jul 3, 2025

Uh oh!

librelois left a comment

Uh oh!

Uh oh!

Enable benchmarks for pallet_xcm_benchmarks #3330

Are you sure you want to change the base?

Enable benchmarks for pallet_xcm_benchmarks #3330

Uh oh!

Conversation

TarekkMA commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Breaking Changes ⚠️

Uh oh!

coderabbitai bot commented Jun 26, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

TarekkMA Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

librelois Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WASM runtime size check:

Compared to target branch

Compared to latest release (runtime-3800)

Uh oh!

Uh oh!

github-actions bot commented Jul 3, 2025

Moonbase Weight Difference Report

Moonriver Weight Difference Report

Moonbeam Weight Difference Report

Uh oh!

librelois left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TarekkMA commented Jun 26, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Jun 27, 2025 •

edited

Loading