-
Notifications
You must be signed in to change notification settings - Fork 384
remove RT4100 migrations #3588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
remove RT4100 migrations #3588
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
WASM runtime size check:Compared to target branchMoonbase runtime: 2120 KB (-4 KB) ✅ Moonbeam runtime: 2240 KB (no changes) ✅ Moonriver runtime: 2240 KB (no changes) ✅ Compared to latest release (runtime-4100)Moonbase runtime: 2120 KB (+184 KB compared to latest release) Moonbeam runtime: 2240 KB (+208 KB compared to latest release) Moonriver runtime: 2240 KB (+208 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master elois-remove-4100-migrations +/- ##
================================================================
- Coverage 76.68% 76.65% -0.03%
- Files 389 388 -1
- Lines 76615 76448 -167
================================================================
- Hits 58745 58598 -147
- Misses 17870 17850 -20
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

What does it do?
Remove migrations executed at runtime version 4100.
What important points should reviewers know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?