Skip to content

Conversation

@librelois
Copy link
Collaborator

What does it do?

Remove migrations executed at runtime version 4100.

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@coderabbitai
Copy link

coderabbitai bot commented Dec 11, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • agent-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch elois-remove-4100-migrations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@librelois librelois added B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Dec 11, 2025
RomarQ
RomarQ previously approved these changes Dec 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2120 KB (-4 KB) ✅

Moonbeam runtime: 2240 KB (no changes) ✅

Moonriver runtime: 2240 KB (no changes) ✅

Compared to latest release (runtime-4100)

Moonbase runtime: 2120 KB (+184 KB compared to latest release) ⚠️

Moonbeam runtime: 2240 KB (+208 KB compared to latest release) ⚠️

Moonriver runtime: 2240 KB (+208 KB compared to latest release) ⚠️

@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025

Coverage Report

@@                       Coverage Diff                        @@
##           master   elois-remove-4100-migrations      +/-   ##
================================================================
- Coverage   76.68%                         76.65%   -0.03%     
- Files         389                            388       -1     
- Lines       76615                          76448     -167     
================================================================
- Hits        58745                          58598     -147     
- Misses      17870                          17850      -20     
Files Changed Coverage
/pallets/parachain-staking/src/tests.rs 98.99% (+0.07%) 🔼
/runtime/common/src/migrations.rs 0.00% (-4.29%) 🔽

Coverage generated Thu Dec 18 14:35:05 UTC 2025

Copy link
Contributor

@RomarQ RomarQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unused dependencies check is failing

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants