[Experimental - DO NOT MERGE] CI: Enable scout workflow on master #3629
+14
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
RomarQ
added
B0-silent
Contributor
Coverage Report@@ Coverage Diff @@
## master rq/enable-scount-on-master +/- ##
==============================================================
+ Coverage 76.55% 76.65% +0.10%
Files 389 389
+ Lines 76684 76960 +276
==============================================================
+ Hits 58704 58991 +287
- Misses 17980 17969 -11
|
Contributor
WASM runtime size check:Compared to target branchMoonbase runtime: 2120 KB (no changes) ✅ Moonbeam runtime: 2232 KB (no changes) ✅ Moonriver runtime: 2236 KB (no changes) ✅ Compared to latest release (runtime-4101)Moonbase runtime: 2120 KB (+184 KB compared to latest release) Moonbeam runtime: 2232 KB (+196 KB compared to latest release) Moonriver runtime: 2236 KB (+204 KB compared to latest release) |
This reverts commit 99a4056.
Contributor
Scout Report - Moonbeam - 2026-01-14Summary
Issues found:
ArithmeticOverflow CheckImpact: Critical Issue: Use Description: An overflow/underflow is typically caught and generates an error. When it is not caught, the operation will result in an inexact result which could lead to serious problems. Findings
|
Contributor
Scout Report - Moonbeam - 2026-01-14Summary
Issues found:
Error HandlingAvoid Panic ErrorImpact: Enhancement Issue: The panic! macro is used in a function that returns Result. Consider using the ? operator or return Err() instead. Description: Using panic! in functions that return Result defeats the purpose of error handling. Consider propagating the error using ? or return Err() instead. Findings
|
RomarQ
changed the title
Contributor
Scout Report - Moonbeam - 2026-01-16Summary
Issues found:
Error HandlingAvoid Panic ErrorImpact: Enhancement Issue: The panic! macro is used in a function that returns Result. Consider using the ? operator or return Err() instead. Description: Using panic! in functions that return Result defeats the purpose of error handling. Consider propagating the error using ? or return Err() instead. Findings
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the result report below, this will not be very helpful for us until they add the following improvements:
File Locationin findings should be a relative path, just having the file name is not enough;