Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hardware benchmarks always running #739

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Fix hardware benchmarks always running #739

merged 2 commits into from
Nov 4, 2024

Conversation

tmpolaczyk
Copy link
Contributor

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024 •
edited
Loading

WASM runtime size check:

Compared to target branch

dancebox runtime: 1412 KB (no changes) ✅

flashbox runtime: 832 KB (no changes) ✅

dancelight runtime: 1988 KB (+1988 KB) ⚠️

container chain template simple runtime: 1096 KB (-4212 KB) ✅

container chain template frontier runtime: 1388 KB (-5136 KB) ✅

@tmpolaczyk tmpolaczyk added B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Nov 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024 •
edited
Loading

Coverage Report

(master)

@@                 Coverage Diff                  @@
##           master   tomasz-then-some      +/-   ##
====================================================
- Coverage   65.31%             65.29%   -0.02%     
  Files         304                304              
+ Lines       53181              53185       +4     
====================================================
- Hits        34733              34722      -11     
+ Misses      18448              18463      +15
Files Changed Coverage
/container-chains/nodes/frontier/src/command.rs 18.13% (-0.60%) ❗
/container-chains/nodes/simple/src/command.rs 17.90% (-0.66%) ❗
/node/src/command.rs 26.67% (-0.79%) ❗
/solo-chains/client/cli/src/command.rs 47.80% (-0.73%) ❗

Coverage generated Mon Nov 4 10:40:14 UTC 2024

@tmpolaczyk tmpolaczyk merged commit 94b94cc into master Nov 4, 2024
42 checks passed
@tmpolaczyk tmpolaczyk deleted the tomasz-then-some branch November 4, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girazoki girazoki girazoki approved these changes

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmpolaczyk @girazoki