Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container candidates in dev service #747

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

girazoki
Copy link
Collaborator

@girazoki girazoki commented Nov 15, 2024

Adds the ability to inject container candidates on dancelights dev service. For now this remains as an opt-in that you can enable in your tests by calling the following rpc in dev mode:

  • mock_enableParaInherentCandidate

similarly you can disable it by calling:

  • mock_disableParaInherentCandidate

I also added a test that proves that when enabled, this mode makes the para-head progress in the relay, indicating the candidates are being inserted.

TODO in this PR:

  • Cleanup
  • tests with rewards being stored

Follow-up tests for future PRs would be:

  • AuthorNoting properly tested: now that we can inject proper headers, we should be able to properly test author-noting inherent, since we need the header to retrieve the author.
  • XCM tests: now that we have the ability to inject candidates we should also be able to put UMP messages in the candidates.

@girazoki girazoki changed the title Girazoki dev service comp Container candidates in dev service Nov 15, 2024
@girazoki girazoki added B0-silent Changes should not be mentioned in any release notes not-breaking Does not need to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Nov 15, 2024
@girazoki girazoki marked this pull request as ready for review November 18, 2024 12:27
Copy link
Contributor

github-actions bot commented Nov 18, 2024

WASM runtime size check:

Compared to target branch

dancebox runtime: 1412 KB (no changes) ✅

flashbox runtime: 832 KB (no changes) ✅

dancelight runtime: 2008 KB (no changes) ✅

container chain template simple runtime: 1088 KB (no changes) ✅

container chain template frontier runtime: 1388 KB (no changes) ✅

Copy link
Contributor

github-actions bot commented Nov 18, 2024

Coverage Report

(master)

@@                      Coverage Diff                      @@
##           master   girazoki-dev-service-comp      +/-   ##
=============================================================
+ Coverage   65.34%                      65.61%   +0.27%     
+ Files         310                         311       +1     
+ Lines       54174                       54348     +174     
=============================================================
+ Hits        35395                       35659     +264     
- Misses      18779                       18689      -90     
Files Changed Coverage
/client/service-container-chain/src/spawner.rs 44.44% (+3.50%)
/container-chains/nodes/frontier/src/command.rs 18.13% (+0.11%)
/container-chains/nodes/simple/src/command.rs 17.90% (+0.11%)
/node/src/service.rs 15.56% (+0.02%)
/solo-chains/node/tanssi-relay-service/src/dev_service.rs 91.57% (+3.29%)

Coverage generated Tue Nov 19 11:38:11 UTC 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant