Open
Conversation
LimpingNinja
requested changes
Jan 15, 2020
Contributor
LimpingNinja
left a comment
There was a problem hiding this comment.
Sorry for the delay, we've got new maintainers now and are culling the backlog.
| try | ||
| { | ||
| reference = TimeZoneInfo.ConvertTimeFromUtc(reference, TimeZoneInfo.Local); | ||
| TimeZoneInfo localTimeZoneInfo = executionContext.OwnerScript.Options.LocalTimeZoneInfo ?? TimeZoneInfo.Local; |
Contributor
There was a problem hiding this comment.
Logic needs to be added to:
src/MoonSharp.Interpreter/_Projects/MoonSharp.Interpreter.netcore/src/CoreLib/OsTimeModule.cs
src/Unity/MoonSharp/Assets/Plugins/MoonSharp/Interpreter/CoreLib/OsTimeModule.cs
If adding this in to the current system; as we push to clean this up it will change, but for now this PR will be accepted if the additional locations are updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TimeZone used by os.time () is hard coded in TimeZoneInfo.LocalTime, but by applying this pull request, it can be changed for each Script object.
ex)