Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Market Reserve Automation #456

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Market Reserve Automation #456

wants to merge 25 commits into from
+3,009 −0

Conversation

ElliotFriedman
Copy link
Collaborator

No description provided.

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Jan 9, 2025 •
edited
Loading

Market Reserve Automation

Generated at commit: 0f560336e2d939b1a68c1d0adcbeacbbfcdc4ad2

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 3
4
0
12
45
64
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

anajuliabit
anajuliabit requested changes Jan 9, 2025
View reviewed changes
src/market/ReserveAutomation.sol Show resolved Hide resolved
src/market/ReserveAutomation.sol Outdated Show resolved Hide resolved
src/market/ReserveAutomation.sol Outdated Show resolved Hide resolved
src/market/ReserveAutomation.sol Show resolved Hide resolved
src/market/ReserveAutomation.sol
}

/// normalize decimals up to 18 if reserve asset has less than 18 decimals
if (reserveAssetDecimals != 18) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to store reserveAssetDecimals as getPriceAndDecimals already gives this value at line 296

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getPriceAndDecimals returns the chainlink decimals.

reserveAssetDecimals deals with the actual token decimals, which chainlink does not

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for USDC we need to normalize the decimals between WELL and USDC, otherwise 1 well ends up buying you 1 trillion USDC due to it having 6 decimals

src/market/ReserveAutomation.sol Show resolved Hide resolved
@ElliotFriedman
add: reserve automation deploy script
162c355 
Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
refactor init params
bf2fd20 
Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
refactor constructor params, add additional checks on deployment
6e33739 
Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
refactor: make validate and deploy function external to ease testing
310fb6b 
Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
make setup virtual for test
7498cdb 
Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
add tests for newly deployed reserve automation contracts directly fr…
fd39fb2 
…om deployment scripts

Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
fix: change buffer updated time based on amount of buffer taken
e51aed2 
Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
add new integration test
9ca8c21 
Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
give mock erc20 token functionality
408375d 
Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
fix error message
56be0b6 
Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
fix test issues
b1f3034 
Signed-off-by: Elliot <[email protected]>
@ElliotFriedman
increment timestamp to fix accrue interest error
6ecb3f6 
Signed-off-by: Elliot <[email protected]>
@ElliotFriedman ElliotFriedman marked this pull request as ready for review January 11, 2025 03:17
@github-actions GitHub Actions
Copy link 

Compiling 4 files with Solc 0.8.19
Solc 0.8.19 finished in 8.33ms
Compiler run successful!
Script ran successfully.
Gas used: 34064219

If you wish to simulate on-chain transactions pass a RPC URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anajuliabit anajuliabit Awaiting requested review from anajuliabit

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElliotFriedman @anajuliabit