LEDG-3333 Fix CardDetails - add FeeProgram #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolaworld
requested review from
adamdecaf,
InfernoJJ and
wadearnold
as code owners
kolaworld
requested review from
atonks2,
a team,
sarumont,
pa3ng,
vxio and
carsonab
and removed request for
wadearnold,
adamdecaf,
InfernoJJ and
a team
InfernoJJ
approved these changes
Jul 8, 2025
|
Can we try to fix up the diff's caused by formatting? |
@InfernoJJ what do you suggest? Move the comment inline? Move the added field 'FeeProgram' to the bottom of the struct definition? |
|
I was referencing the lines that changed only because of formatting changes. I would just match what was there. |
kolaworld
commented
Jul 8, 2025
| @@ -128,26 +128,6 @@ func CreateTemporaryTestAccount(t *testing.T, mc *moov.Client, create moov.Creat | |||
| return account | |||
| } | |||
|
|
|||
| func createTemporaryBankAccount(t *testing.T, mc *moov.Client, accountID string) *moov.BankAccount { | |||
kolaworld
commented
Jul 8, 2025
| @@ -52,7 +52,7 @@ func Test_SweepConfig_CRUD_Endpoints(t *testing.T) { | |||
| require.NoError(t, err) | |||
|
|
|||
| // Get by ID | |||
| sweepConfig, err = mc.GetSweepConfig(ctx, accountID, sweepConfig.SweepConfigID) | |||
| _, err = mc.GetSweepConfig(ctx, accountID, sweepConfig.SweepConfigID) | |||
InfernoJJ
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test_Transfers/list_transferstest failure:json: unknown field "feeProgram"CardDetails.FeeProgramfield to match moov-api specCardDetails.InterchangeQualificationas deprecated per spec ^