Conversation
greenlet < 0.5 conflicts with SQLAlchemy 1.4 which installs greenlet 1.0 the greenlet API should not have changed between 0.5 and < 2 according to benoitc/gunicorn#2541 (comment)
|
Thanks for doing this! |
Update greenlet to 1.0.0.
meinheld declares a dependency to greenlet <0.5, but according to [1]
and [2], there are no API or ABI changes leading to greenlet-1.0.0, so
it seems reasonable to drop the strict requirement. This commit
uses substituteInPlace to patch setup.py since no upstream commit has
landed in the main branch yet.
Morehover, quoting [2]:
Prior to greenlet 1.0 there were no semantic meanings attached to
greenlet versions — API and ABI regularly changed from 0.4.x
to 0.4.x+1, so their current pin doesn't make much sense anyway.
nix-review reveals few broken packages that are also broken in master.
[1] mopemope/meinheld#123
[2] benoitc/gunicorn#2541 (comment)
|
I'm running into the version mismatch as well, are there any plans to merge this PR soon or should we find an alternative for now? |
|
Any chance that we can get this merged? I hit some esoteric bugs in SQLAlchemy 1.3 and would like to upgrade to the latest version. Thanks! |
|
Any updates on a merge timeline? |
|
We're having the same version mismatch issue with gevent. |
|
Hi what's to do before we merge this PR? |
|
@mopemope it has been a lot of time and this fix has not been merged yet, checks have passed, could you merge it or find a solution, because the conflict with SQLAlchemy is a huge issue for a lot of projects |
|
Until this PR gets merged, a temporal solution would be to install the package from the patched branch provided by @idot pip3 install --user git+https://github.com/idot/meinheld.git@patch-1 |
This should work, but I recommend using commit hash instead of branch for security reasons. |
|
@mopemope Do you still maintain this project now? There are 2 PRs which looks good and actually fix some problems. |
You can do that like this: pip3 install git+https://github.com/idot/meinheld.git@2bfe452d6608c92688d92337c87b1dd6448f4ccbAlso note that I've omitted that |
9 participants
greenlet < 0.5 conflicts with SQLAlchemy 1.4 which installs greenlet 1.0
the greenlet API should not have changed between 0.5 and < 2 according to
benoitc/gunicorn#2541 (comment)