Skip to content
This repository was archived by the owner on Aug 30, 2025. It is now read-only.

Removes commonTrackProperties and SelectionParameters #65

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Removes commonTrackProperties and SelectionParameters #65

wants to merge 1 commit into from

Conversation

@wilaw
Copy link
Collaborator

@wilaw wilaw commented Jul 25, 2024

This PR simplifies the structure of the catalog by:

  1. Removing the commonTrackProperties object. All properties are now repeated for each track.
  2. Removing selectionParameters object. Conceivable , any track property can be used for selection, therefore it is arbitrary to group a subset of them within an object designed for selection.

Fixes #53
Fixes #52

All examples updated to match.

@wilaw wilaw requested a review from kixelated July 25, 2024 12:53
kixelated
kixelated approved these changes Jul 25, 2024
View reviewed changes
Copy link

@kixelated kixelated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much simpler, thanks Will.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kixelated kixelated kixelated approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

commonTrackFields is a premature optimization Collapse selectionParams

3 participants

@wilaw @kixelated