Skip to content

Conversation

@yekuiwang
Copy link
Contributor

@yekuiwang yekuiwang commented Oct 22, 2025

I was reviewing @afrind's #1332 and noticed a few places inconsistent use of "Established subscription", but I could not directly suggest changes for some of the places therein, then I tried reviewing in codespace, made the changes, but did not know how to suggest the changes, and by trial and error a couple of times, I ended up submitting this PR, which seems to not only include the minor changes for consistent use of "Established subscription", but also include all changes in #1332.

@afrind Please feel free to apply the intended additional changes herein to your #1332 and then close this one.

afrind and others added 3 commits October 22, 2025 14:08
This creates a mechanism to refresh auth credentials for PUBLISH, SUBSCRIBE_NAMESPACE and PUBLISH_NAMESPACE.

A side-effect is that it allows the subscriber to change the priority of a FETCH (we closed moq-wg#1204 already but this would address it).

If we decide to address moq-wg#1270, this will help.

Fixes: moq-wg#1267 
Fixes: moq-wg#1204
@afrind
Copy link
Collaborator

afrind commented Oct 22, 2025

You branched off 1332, which makes this appear to have those changes.

@afrind
Copy link
Collaborator

afrind commented Oct 22, 2025

This commit 6d570c8 looks good

@yekuiwang
Copy link
Contributor Author

@afrind I just explained above what happened. Copying here FYI:

I was reviewing @afrind's #1332 and noticed a few places inconsistent use of "Established subscription", but I could not directly suggest changes for some of the places therein, then I tried reviewing in codespace, made the changes, but did not know how to suggest the changes, and by trial and error a couple of times, I ended up submitting this PR, which seems to not only include the minor changes for consistent use of "Established subscription", but also include all changes in #1332.

@afrind Please feel free to apply the intended additional changes herein to your #1332 and then close this one.

@afrind
Copy link
Collaborator

afrind commented Oct 22, 2025

Will make another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants