Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Group Order for Subscribes #636

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove Group Order for Subscribes #636

wants to merge 3 commits into from

Conversation

suhasHere
Copy link
Collaborator

Fixes #607

@afrind
Copy link
Collaborator

afrind commented Dec 4, 2024

Individual Comment: lgtm

@ianswett ianswett added Subscribe Related to SUBSCRIBE message and subscription handling Design Issues or PRs that change how MoQ works including the wire format. labels Dec 10, 2024
fluffy
fluffy approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@fluffy fluffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martinduke
Copy link
Contributor

martinduke commented Jan 8, 2025 •
edited
Loading

as chair: There is rough consensus for this change.

@vasilvv
Copy link
Collaborator

vasilvv commented Jan 8, 2025

Really odd to see this going from "needs more discussion" on Dec 18 to "rough consensus" on Jan 8. Have I missed something?

@englishm
Copy link
Collaborator

Really odd to see this going from "needs more discussion" on Dec 18 to "rough consensus" on Jan 8. Have I missed something?

I am also surprised to see this.

@martinduke
Copy link
Contributor

As chair: our understanding was that Victor was the sole objector and Ian and Victor discussed this.

@englishm do you also object?

@englishm
Copy link
Collaborator

Yes, I also object to the removal of Group Order. I think removing this feature would be a loss of functionality in a set of scenarios where further experimentation would be desirable.

See my earlier comment on how delivery timeout does not sufficiently cover all possible cases here:
#607 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianswett ianswett ianswett approved these changes

@fluffy fluffy fluffy approved these changes

Assignees
No one assigned
Labels
Design Issues or PRs that change how MoQ works including the wire format. Subscribe Related to SUBSCRIBE message and subscription handling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do we need Group Order for Subscriptions ?
7 participants
@suhasHere @afrind @martinduke @vasilvv @englishm @fluffy @ianswett