-
Notifications
You must be signed in to change notification settings - Fork 31
Do not fail SUBSCRIBEs that start in the past #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes #595 It's difficult or possibly even impossible to prevent it.
Contrary to the title, this PR is not allowing a SUBSCRIBE to start in the past. It is taking a SUBSCRIBE that wants to start in the past, and coercing it to instead start at the beginning of the current group? |
Good point will, I retitled this PR. |
draft-ietf-moq-transport.md
Outdated
StartGroup is prior to the current group, the subscription starts at the | ||
beginning of the current group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Individual Comment:
I'd say if the specified start point is prior to the latest seen object, the subscription starts at the next object .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 with @afrind with minor tweaks .. "If the specified StartGroup is prior to the latest seen object, then the subscriptions starts at the latest group and object seen at the publisher ( as if the filter was Latest Object)"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mention the Latest Object filter now. I think it might be worth filing an issue for exactly what Object is delivered first for the Latest Object filter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few minor suggestions to clarify.
I made some minor updates, but I think a larger change is likely required to clarify what Objects one expects to receive. #592 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a useful incremental change to get to where we want to with clarifying Subscribe and Fetch. LGTM
Fixes #595
It's difficult or possibly even impossible to prevent it.