Skip to content

Move error codes to message descriptions, include newer error messages #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ianswett merged 145 commits into from
Feb 6, 2025
Merged

Move error codes to message descriptions, include newer error messages #656

ianswett merged 145 commits into from
Feb 6, 2025

Conversation

@martinduke
Copy link
Contributor

@martinduke martinduke commented Jan 21, 2025 •
edited
Loading

The error codes are currently in the "Relays" section, which doesn't make any sense.

It's also missing codes for SUBSCRIBE_ANNOUNCES_ERROR, ANNOUNCE_ERROR, and FETCH_ERROR.

Also fixes #577.

@martinduke martinduke requested review from afrind and removed request for kixelated, suhasHere and vasilvv January 21, 2025 21:57
afrind
afrind reviewed Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@afrind afrind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this. Do we need to look at Track Status responses too?

@martinduke
Copy link
Contributor Author

martinduke commented Jan 21, 2025

Thank you for doing this. Do we need to look at Track Status responses too?

I don't want to take that on in this PR. These are mostly obvious tweaks from SUBSCRIBE_ERROR to *_ERROR.

suhasHere
suhasHere reviewed Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@suhasHere suhasHere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems ok , but rather duplicated ..

afrind
afrind reviewed Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@afrind afrind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Individual Comments

@martinduke
Copy link
Contributor Author

martinduke commented Jan 22, 2025

this seems ok , but rather duplicated ..

Agreed, but each of the messages has a couple of slightly different error conditions, unfortunately.

@martinduke martinduke mentioned this pull request Jan 22, 2025
Merged
@martinduke martinduke self-assigned this Jan 29, 2025
ianswett
ianswett approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG once you update the name and fix the merge conflicts.

@martinduke
Revert "Rebase"
e7d07eb 
This reverts commit 85d6fd7.
@martinduke
Revert "rebase hell"
19a20cd 
This reverts commit 4c1c05d.
@martinduke
Revert "Automatic update of .github/CODEOWNERS"
36d1a33 
This reverts commit e7aa187.
@martinduke
Revert "Automatic update of README.md"
2586987 
This reverts commit df57a25.
@martinduke
Revert "Automatic update of .github/workflows/update.yml"
57a7c45 
This reverts commit 8d512da.
@martinduke
Revert "Automatic update of .github/workflows/archive.yml"
79f4e44 
This reverts commit 532203c.
@martinduke
Revert "Automatic update of .github/workflows/publish.yml"
105bb4a 
This reverts commit e4aabec.
@martinduke
Revert "Automatic update of .github/workflows/ghpages.yml"
e52f8ae 
This reverts commit f3e4409.
@martinduke
Revert "Automatic update of Makefile"
b03d77c 
This reverts commit cdcc63b.
@martinduke
Revert "Automatic update of .gitignore"
f403161 
This reverts commit 2cfe934.
@martinduke
Revert "lint"
9f21679 
This reverts commit 4655de8.
@martinduke
Revert "SHOULD to MUST"
234c1b6 
This reverts commit fab5a7c.
@martinduke
Revert "caching for FETCH"
59b5f5b 
This reverts commit 32b22a6.
@martinduke
Revert "Add FETCH to Relay section"
e5cf20e 
This reverts commit 78a7bf1.
@martinduke
Revert "Update draft-ietf-moq-transport.md"
f17ce5f 
This reverts commit c6b7584.
@martinduke
Revert "fix whitespace"
e71bd86 
This reverts commit 1888ad5.
@martinduke
Revert "Add session errors for control and data timeout"
cd098b4 
This reverts commit 92d11b1.
@martinduke
Revert "Update draft-ietf-moq-transport.md"
28a74da 
This reverts commit 1bd5fe7.
@martinduke
Revert "Update draft-ietf-moq-transport.md"
198565e 
This reverts commit 91447fc.
@martinduke
Revert "Editorial changes"
36f160b 
This reverts commit 7e78c15.
@martinduke
Merge branch 'main' into error-codes
7d901b8
@martinduke
Copy link
Contributor Author

martinduke commented Jan 30, 2025

I guess this is done, although git, as usual, is being stupid. I don't think any errors crept in, but I'm not sure.

fluffy
fluffy approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@fluffy fluffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is 100% editorial but LGTM.

@ianswett ianswett merged commit 773a241 into main Feb 6, 2025
2 checks passed
@martinduke martinduke mentioned this pull request Feb 19, 2025
Closed
@englishm englishm mentioned this pull request Feb 25, 2025
Open
39 tasks
This was referenced Mar 6, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suhasHere suhasHere suhasHere left review comments

@afrind afrind afrind left review comments

@fluffy fluffy fluffy approved these changes

@ianswett ianswett ianswett approved these changes

Assignees

@martinduke martinduke

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Errors from Announce

8 participants

@martinduke @fluffy @suhasHere @afrind @ianswett @gloinul @ac-freeman