Move error codes to message descriptions, include newer error messages #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinduke
requested review from
kixelated,
suhasHere,
vasilvv and
ianswett
as code owners
martinduke
requested review from
afrind
and removed request for
vasilvv,
kixelated and
suhasHere
afrind
reviewed
Jan 21, 2025
I don't want to take that on in this PR. These are mostly obvious tweaks from SUBSCRIBE_ERROR to *_ERROR. |
suhasHere
reviewed
Jan 22, 2025
Agreed, but each of the messages has a couple of slightly different error conditions, unfortunately. |
ianswett
approved these changes
Jan 30, 2025
Co-authored-by: ianswett <[email protected]>
Co-authored-by: ianswett <[email protected]>
Co-authored-by: Mathis Engelbart <[email protected]>
This reverts commit 85d6fd7.
This reverts commit 4c1c05d.
This reverts commit e7aa187.
This reverts commit df57a25.
This reverts commit 8d512da.
This reverts commit 532203c.
This reverts commit e4aabec.
This reverts commit f3e4409.
This reverts commit cdcc63b.
This reverts commit 2cfe934.
This reverts commit 4655de8.
This reverts commit fab5a7c.
This reverts commit 32b22a6.
This reverts commit 78a7bf1.
This reverts commit c6b7584.
This reverts commit 1888ad5.
This reverts commit 92d11b1.
This reverts commit 1bd5fe7.
This reverts commit 91447fc.
This reverts commit 7e78c15.
|
I guess this is done, although git, as usual, is being stupid. I don't think any errors crept in, but I'm not sure. |
ianswett
approved these changes
Feb 5, 2025
fluffy
approved these changes
Feb 5, 2025
39 tasks
This was referenced Mar 6, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error codes are currently in the "Relays" section, which doesn't make any sense.
It's also missing codes for SUBSCRIBE_ANNOUNCES_ERROR, ANNOUNCE_ERROR, and FETCH_ERROR.
Also fixes #577.