Change Subscription ID to Request ID, add to all requests #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more wire efficient and less ambiguous Fixes: #804
Co-authored-by: ianswett <[email protected]>
afrind
added
the
Design
ianswett
approved these changes
Apr 2, 2025
Co-authored-by: ianswett <[email protected]>
DanielFay22
approved these changes
Apr 6, 2025
sharmafb
approved these changes
Apr 15, 2025
gloinul
approved these changes
Apr 16, 2025
martinduke
approved these changes
Apr 16, 2025
draft-ietf-moq-transport.md
Outdated
| requests, and supports the endpoint's ability to limit the concurrency and | ||
| frequency of requests. There are independent Request IDs for each endpoint. The | ||
| client's Request ID starts at 0 and are even and the server's Request ID starts | ||
| at 1 and are odd. The Request ID increments by 2 with ANNOUNCE, FETCH, |
Contributor
There was a problem hiding this comment.
There is probably a reason for this client/server separation that is very smart, but I can't see what it is.
Collaborator
Author
There was a problem hiding this comment.
It's not strictly necessary (subscribe ID does not do this) but it reduces confusion, so that Request ID=X is unambiguous.
Collaborator
There was a problem hiding this comment.
need a bit of clarification this count is scoped within a connection ... if a new connection was formed, counts would start over
fluffy
approved these changes
Apr 16, 2025
suhasHere
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an expansion/alternate to #898 that also addresses #903
Fixes: #804
Fixes: #903
Related to #350