-
Notifications
You must be signed in to change notification settings - Fork 31
Clarify how SUBSCRIBE filters work, allow Absolute start before Latest #927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some mostly editorial suggestions, but LG
Co-authored-by: ianswett <[email protected]>
@@ -1391,31 +1391,41 @@ single session and publishers SHOULD treat this as a protocol violation. | |||
The subscriber specifies a filter on the subscription to allow | |||
the publisher to identify which objects need to be delivered. | |||
|
|||
There are 3 types of filters: | |||
All filters have a Start Location and an optional End Group. Only objects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonder why is it EndGroup and not End Location?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#593 removed End Object from Absolute Range.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm . I missed this somehow. Thanks for sharing the PR. That PR does say this "Specifies a closed subscription starting at StartObject
in StartGroup and ending at EndObject in EndGroup."
I wonder if removing the EndObject was resolving any issue. Sorry for missing it earlier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ianswett do you have the linked issue for that?
the subscription starts with the first published or received group. | ||
The `Largest Object` is defined to be the object with the largest Location | ||
({{location-structure}}) in the track from the perspective of the endpoint | ||
processing the SUBSCRIBE message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since the term "LargestObject" is used in multiple places, may be it will benefit from a sub-section so that all the usages refer to the same defintion. It need not be in this PR and we can create a new issue to track, if it helps.
draft-ietf-moq-transport.md
Outdated
The Start Location MAY be less than the `Largest Object`. There is no End Group | ||
- the subscription is open ended. To receive any object that is published or | ||
is received after this subscription is processed, a subscriber can use an | ||
AbsoluteStart filter with Start Location = {0, 0}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm this is a way of supporting all objects ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, all Objects published or received via subscription pass a filer that starts at {0,0} and has no End Group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. This seems to be clarifying. I did had few clarificatin questions and some design comments too. Please let me know your thoughts. Thanks
Co-authored-by: Suhas Nandakumar <[email protected]>
Maybe adding some cases like subgroup can be clearer to readers? |
This is an alternate to #853, attempting to resolve #758.
Fixes: #758
Closes #726