Skip to content

Update moquette-broker coordinates to resolve the 401 unauthorized error from Jitpack #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2025

Conversation

dskarzh
Copy link
Contributor

@dskarzh dskarzh commented Mar 27, 2025

This PR corrects instructions in README.md on how to embed moquette in other projects

Copy link
Collaborator

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment to know your opinion on the version name v0.18.0 vs 0.18.0

README.md Outdated
<artifactId>moquette-broker</artifactId>
<version>0.18.0</version>
<version>v0.18.0</version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh it's the tag name and Moquette always used vM.M.P format. I think it's ugly to use

<version>v0.18.0</version>

If you also feel the same, I think I should switch tag policy to remove the v from the tag.
In past I used that to distinguish tags from version branches.

Let me know what do you think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely agree that the v prefix is not only ugly but also unusual in the Java ecosystem.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created tag 0.18.0 https://github.com/moquette-io/moquette/tree/0.18.0 so you could drop the v from the version tag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. That works, though group ID still missing .moquette. I updated the PR to omit v prefix.

@andsel andsel self-requested a review April 26, 2025 16:29
Copy link
Collaborator

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andsel andsel merged commit 8b97767 into moquette-io:main Apr 26, 2025
3 of 4 checks passed
@andsel
Copy link
Collaborator

andsel commented Apr 26, 2025

Thanks @dskarzh for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants