-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic version of Sequence
for any number type
#893
Conversation
399fbc4
to
f1bf4e8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #893 +/- ##
==========================================
- Coverage 93.23% 93.22% -0.01%
==========================================
Files 112 112
Lines 3400 3410 +10
Branches 962 962
==========================================
+ Hits 3170 3179 +9
- Misses 214 215 +1
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Approved in principle. Will wait to give final approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should wait until v4.0.0, along with .net7 release. Expectation is that v3.4.0 is existing changes plus nullability fixes to include at most .net6 (including conflicting behavior in certain methods). Future improvements should be delayed until after 3.4.0 is released.
…quence Conflicts resolved: - MoreLinq/MoreLinq.csproj
This PR adds a generic version of
Sequence
as described in #892.Under .NET 7,
Sequence(int, int, int)
defers toSequence<T>(T, T, T)
and is therefore tested for whenT
isint
.