fix: refactor code to use getDerivedStateFromProps#735
Open
AdrianInsua wants to merge 2 commits intomoroshko:masterfrom
AdrianInsua:bugfix/#624
Open
fix: refactor code to use getDerivedStateFromProps#735AdrianInsua wants to merge 2 commits intomoroshko:masterfrom AdrianInsua:bugfix/#624
AdrianInsua wants to merge 2 commits intomoroshko:masterfrom
AdrianInsua:bugfix/#624
Conversation
|
@AdrianInsua Is this still in-progress? |
Author
|
@TaiWilkin the PR was done several months ago, but it seems to have conflicts now, as soon as i have some free time i will fix them |
|
@pimterry @FullstackJack @AdrianInsua |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr will fix #624
In order to do this the code is refactored to use
static getDerivedStateFromProps. Considering that the method is static i've moved the methods used inside oldwillReceivePropsout of the class to avoid repeated code (because we can't callthisin static methods).Also i've moved
justPressedUpDownjustMouseEnteredjustSelectedSuggestioninto state to acces them in the static method.Finally i've added a new state variable
prevSuggestionsto emulateprevProps.suggestionsbehaviour.The demo page works fine, but i had some problems with prettier script on build process
(but it works ok without it).
I`m not a React developer so please check the code and let me know if something is wrong