Add aria-label prop for listbox element#770
Conversation
|
So here you seem to re-use some commits from PR #645... This PR might be easier to review if you did it all in one commit that includes an updated README and also new tests. Especially, the README-change you cherry-picked from #645 is no longer accurate. Here you change the aria-label of the I understand we use |
|
@hugoholgersson you are right on all counts. Thanks for looking. I'll take care of that soon as possible |
|
Looks promising. Any chance to see that PR merged? @sbeam |
|
Without this fix, it’s impossible for a react-autosuggest implementation to be "WAI-ARIA compliant" as it says on the tin. Would be great to get this merged, as well as removing the extra In the meantime here is an alternative: #778 (comment). |
Our accessibility audit revealed that an
aria-labelattribute was required on the search results listing given by theul[role=listboxelement. These changes make it possible to pass this down as an optional prop.