Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Certora] Stay healthy liquidate #684

Merged
merged 15 commits into from
Sep 30, 2024
Merged

[Certora] Stay healthy liquidate #684

merged 15 commits into from
Sep 30, 2024

Conversation

QGarchery
Copy link
Contributor

@QGarchery QGarchery commented Jul 5, 2024 •
edited
Loading

Todo:

  • make sure that it goes through
  • refactor the rule to align its style with the rest
  • wait for it to pass on certora-cli, and switch to certora-cli

@QGarchery QGarchery added the verif Modifies the formal verification label Jul 5, 2024
@QGarchery QGarchery self-assigned this Jul 5, 2024
@QGarchery QGarchery marked this pull request as ready for review August 29, 2024 09:45
MathisGD
MathisGD reviewed Sep 1, 2024
View reviewed changes
certora/specs/Health.spec Outdated Show resolved Hide resolved
certora/specs/Health.spec Outdated Show resolved Hide resolved
certora/specs/Health.spec Outdated Show resolved Hide resolved
certora/specs/Health.spec Outdated Show resolved Hide resolved
certora/specs/Health.spec Outdated Show resolved Hide resolved
MathisGD
MathisGD reviewed Sep 30, 2024
View reviewed changes
certora/specs/StayHealthy.spec Show resolved Hide resolved
certora/specs/Health.spec Show resolved Hide resolved
certora/specs/StayHealthy.spec Show resolved Hide resolved
certora/specs/StayHealthy.spec Show resolved Hide resolved
certora/specs/StayHealthy.spec Show resolved Hide resolved
certora/specs/StayHealthy.spec Outdated Show resolved Hide resolved
certora/specs/StayHealthy.spec Outdated Show resolved Hide resolved
certora/specs/StayHealthy.spec Show resolved Hide resolved
certora/specs/StayHealthy.spec Show resolved Hide resolved
QGarchery and others added 3 commits September 30, 2024 16:07
@QGarchery
docs: adapt README
eb6c5b6
@QGarchery @MathisGD
docs: fix spec of no borrow
8282907 
Co-authored-by: MathisGD <[email protected]>
Signed-off-by: Quentin Garchery <[email protected]>
@QGarchery @MathisGD
chore: remove unnecessary variable definition
90c3c8e 
Co-authored-by: MathisGD <[email protected]>
Signed-off-by: Quentin Garchery <[email protected]>
colin-morpho
colin-morpho approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@colin-morpho colin-morpho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, can be dismissed.

@MathisGD MathisGD merged commit fcb190b into main Sep 30, 2024
15 of 17 checks passed
@MathisGD MathisGD deleted the certora/stay-healthy-liquidate branch September 30, 2024 21:01
@MathisGD MathisGD mentioned this pull request Sep 30, 2024
Open
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathisGD MathisGD MathisGD approved these changes

@colin-morpho colin-morpho colin-morpho approved these changes

Assignees

@QGarchery QGarchery

Labels
verif Modifies the formal verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QGarchery @MathisGD @colin-morpho