Halmos Test Properties migrated to Certora #747
+72
−227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lastUpdateCannotDecrease, irmCannotBeDisabled, lltvCannotBeDisabled, idToMarketParamsForCreatedMarketCannotChange
MathisGD
reviewed
Jan 6, 2026
MathisGD
reviewed
Jan 6, 2026
MathisGD
approved these changes
Jan 7, 2026
This was referenced Jan 7, 2026
QGarchery
reviewed
Jan 12, 2026
| MorphoHarness.Id id; | ||
|
|
||
| require e.block.timestamp <= max_uint128; | ||
| // Assume the property before the interaction. |
Contributor
There was a problem hiding this comment.
Let's add this everywhere since the file had it before. Other option is to refactor the file to use reason strings on require statements, as you prefer
| { | ||
| MorphoHarness.Id id; | ||
|
|
||
| require e.block.timestamp <= max_uint128; |
Contributor
There was a problem hiding this comment.
We can document why this requirement is ok (extremely far in the future), same for occurrences below
Comment on lines
-183
to
-190
| function check_nonceCannotDecrease(bytes4 selector, address caller, address user) public { | ||
| uint256 nonceBefore = morpho.nonce(user); | ||
|
|
||
| _callMorpho(selector, caller); | ||
|
|
||
| uint256 nonceAfter = morpho.nonce(user); | ||
| assert(nonceAfter == nonceBefore || nonceAfter == nonceBefore + 1); | ||
| } |
Contributor
There was a problem hiding this comment.
We can recover this one in Certora as well
Contributor
There was a problem hiding this comment.
Now we can also move tests one folder down: test/forge -> test 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We intend to remove the halmos tests in Morpho Blue. This PR introduces certora rules for Halmos tested properties that were already not proved with Certora.
Interestingly, the properties
lastUpdateNonZeroandlastUpdateCannotDecreaseneeded an assumption that timestamp is <= max_uint128. Else, the explicit cast here can makelastUpdatedzero. Surprisingly, this was not required in Halmos. Time permitting, we can create a halmos bug report.