Rename PreLiquidation -> SoftLiquidation #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QGarchery
reviewed
Oct 4, 2024
| }); | ||
| } | ||
|
|
||
| /* CONSTRUCTOR */ | ||
|
|
||
| /// @dev Initializes the PreLiquidation contract. | ||
| /// @dev Initializes the SoftLiquidation contract. |
There was a problem hiding this comment.
This comment is useless IMO
There was a problem hiding this comment.
I took it from the metamorpho repo but yes I agree
There was a problem hiding this comment.
We can keep it for consistency.
QGarchery
reviewed
Oct 5, 2024
QGarchery
approved these changes
Oct 6, 2024
|
Don't need to change the schema in the README, as it is already done in #77 |
MathisGD
reviewed
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WIP
Should close #34