Merged
Conversation
…tely need the numged patch
renamed file Signed-off-by: Bhargav Bhatt <[email protected]>
36 tasks
QGarchery
reviewed
Feb 16, 2026
jhoenicke
requested changes
Feb 17, 2026
Collaborator
jhoenicke
left a comment
jhoenicke
left a comment
There was a problem hiding this comment.
You should either havoc ghostBalances in the token transfer function, or use a nondet value instead of a ghost function. Otherwise the ghostBalances don't change on transfer.
QGarchery
approved these changes
Feb 20, 2026
jhoenicke
reviewed
Mar 2, 2026
Collaborator
jhoenicke
left a comment
jhoenicke
left a comment
There was a problem hiding this comment.
Some minor typos.
Otherwise the rules look fine.
Contributor
Author
|
@jhoenicke thanks, the minor issues are ironed out, should be good to merge after @MathisGD review |
Collaborator
|
LGTM, still some typos to fix and |
Collaborator
|
Looks like your last commit removed also |
Contributor
Author
|
@jhoenicke indeed, i think it should be good now |
QGarchery
approved these changes
Mar 5, 2026
MathisGD
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
properties verified separately for MarketV1AdapterV2 and VaultV1Adapter
skim()does not change vault accounting, i.e., vault funds can't be stolen by skimmingsetSkimRecipient()