Skip to content

README cleanup, tutorial directory #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

justinGilmer
Copy link

Added a directory containing the previous examples.

Created a blank template including all the OpenMM definitions.
Users can remove/add to these as they please

Need to add more about SMARTS however.

Added a directory containing the previous examples.

Created a blank template including all the OpenMM definitions.
Users can remove/add to these as they please

Need to add more about SMARTS however.
@justinGilmer
Copy link
Author

Should we include a readme in the tutorial section for SMARTS?

Most of that is being covered in foyer's readmes. tutorial.md might not be necessary if thats the case.

Unsure what would be necessary for the documentation besides that.

@ctk3b
Copy link
Member

ctk3b commented May 15, 2017

Any updates on this? Looks like you've re-arranged it to be template + tutorial as we talked about.

What's left to do from your perspective?

Also one suggestion: adding links to the relevant openmm XML docs for each entry could be convenient.

@justinGilmer
Copy link
Author

Just finishing the markdown document now.

i went through and have some graphics to show the process to test the examples and what the expected output should be.

Putting that together now.

Revamped tutorial directory, blank template for user to work through.
Included minimal walk through for tutorial.

Images need work in tutorial, best I could do with my current resources.

Passing forcefield template in top directory.

Relative links where possible in the README's

Image directory for including in tutorial, not all used.
removed superflous images
emulator of choice within this directory.
```bash
py.test -v test_atomtyping.py --tb=line
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brief description of options

def="H[C;X4]"
```
An important distinction should be pointed out here. In a `SMARTS`
definition, the first atom in the string is the atom of interest.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BOLD AND TRIPLE DOUBLE UNDERLINED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants