Update rpc.py #369
Open
Update rpc.py #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python3.9 rpc.py fix
mosquito
reviewed
Feb 16, 2021
| ) | ||
|
|
||
| def on_close(self, exc=None): | ||
| def on_close(self, exc=None, _=None): |
There was a problem hiding this comment.
Could you please add some details why python 3.9 adding an argument here?
There was a problem hiding this comment.
I believe this is not due to python 3.9, rather it is a regression from 1625f37e4056c355e9b20962f39f8ba6e66e953a.
I have tried with python 3.6 onward and the attached Dockerfile reproduces the issue that is solved by this PR.
Dockerfile.zip
The issue does not exist in aio-pika 6.6.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python3.9 rpc.py fix