add robust_connection_multihost.py #680
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to add some tests |
|
Fixes #141 |
mosquito
requested changes
Jun 27, 2025
| super().__init__(str(self.urls[0]), **kwargs) | ||
|
|
||
| def _prepare_url(self, url: str, default_port: int) -> URL: | ||
| if not url.startswith("amqp://"): |
There was a problem hiding this comment.
I should consider that! right, thanks
| from aio_pika.robust_connection import RobustConnection | ||
| import asyncio | ||
|
|
||
| class RobustConnectionMultiHost(RobustConnection): |
There was a problem hiding this comment.
RobustConnectionRRHost semantically it is closer, because you connection is not a multihost, it is a round-robin retying to connect only to one.
There was a problem hiding this comment.
right, thanks. I'm going to review the module and add some tests
| await super()._on_connection_close(closing) | ||
|
|
||
| async def reconnect(self): | ||
| await asyncio.sleep(2) |
federicsp
force-pushed
the
feat/add_robust_connection_multihost
branch
from
db67837 to
fee1abe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RobustConnectionMultiHost class for fault-tolerant RabbitMQ connections:
Implements a connection class that tries multiple broker URLs in sequence until one succeeds.
Automatically handles reconnection on unexpected connection closures.