Skip to content

Conversation

asmaloney
Copy link
Contributor

No description provided.

@asmaloney
Copy link
Contributor Author

There doesn't seem to be anything I can do about this AppVeyor issue. It just cancelled stuff on its own…

@mosra
Copy link
Owner

mosra commented Jul 7, 2025

Hah, sorry, I did that cancel :D

Is there any particular feature in the update you rely on? I wanted to take the update as an opportunity to finally implement kerning in this plugin, but it'll take a bit more time.

@mosra mosra added this to the 2025.0a milestone Jul 7, 2025
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.60%. Comparing base (9f31cf5) to head (c2f6158).
⚠️ Report is 20 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   97.60%   97.60%           
=======================================
  Files         156      156           
  Lines       17113    17113           
=======================================
  Hits        16703    16703           
  Misses        410      410           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asmaloney
Copy link
Contributor Author

Is there any particular feature in the update you rely on?

No—I'd just updated it hoping to get better results and so decided to submit it since it seemed to have a bunch of fixes.

Kerning would be awesome—that's probably what's causing some of my issues!

Thanks Vladimír!

@mosra
Copy link
Owner

mosra commented Jul 7, 2025

that's probably what's causing some of my issues

Feel free to list them here.

Currently (for the UI library in magnum-extras) main effort goes into HarfBuzzFont which implements kerning along with ligatures and all other OpenType features, and StbTrueTypeFont doesn't get as much attention in comparison. So let me know what else would you need and I can look into that.

@asmaloney
Copy link
Contributor Author

Feel free to list them here.

I've switched off of this for now, but the obvious one was that the letters were clipped. Not sure if that's a kerning issue. When I switch back I'll post some images.

I did try to integrate the HarfBuzz solution, but integrating it + its dependencies like the FreeType lib (across platforms) was a pain, so I was hoping to keep it simple.

(Aside: Also ran across kb_text_shape.h the other day—might be of interest!)

@asmaloney
Copy link
Contributor Author

I've decided to let Qt render my text for now, so please feel free to close this one if it's of no use.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants