-
Notifications
You must be signed in to change notification settings - Fork 63
Update stb_truetype.h from 1.21 to 1.26 #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There doesn't seem to be anything I can do about this AppVeyor issue. It just cancelled stuff on its own… |
Hah, sorry, I did that cancel :D Is there any particular feature in the update you rely on? I wanted to take the update as an opportunity to finally implement kerning in this plugin, but it'll take a bit more time. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #149 +/- ##
=======================================
Coverage 97.60% 97.60%
=======================================
Files 156 156
Lines 17113 17113
=======================================
Hits 16703 16703
Misses 410 410 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No—I'd just updated it hoping to get better results and so decided to submit it since it seemed to have a bunch of fixes. Kerning would be awesome—that's probably what's causing some of my issues! Thanks Vladimír! |
Feel free to list them here. Currently (for the UI library in magnum-extras) main effort goes into HarfBuzzFont which implements kerning along with ligatures and all other OpenType features, and StbTrueTypeFont doesn't get as much attention in comparison. So let me know what else would you need and I can look into that. |
I've switched off of this for now, but the obvious one was that the letters were clipped. Not sure if that's a kerning issue. When I switch back I'll post some images. I did try to integrate the HarfBuzz solution, but integrating it + its dependencies like the FreeType lib (across platforms) was a pain, so I was hoping to keep it simple. (Aside: Also ran across kb_text_shape.h the other day—might be of interest!) |
I've decided to let Qt render my text for now, so please feel free to close this one if it's of no use. Thank you! |
No description provided.