-
Notifications
You must be signed in to change notification settings - Fork 83
Allow to set the maximum number of transfers in the UI #910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
A maxTransfers UI element is added for the isochrones over in #891 as well. While I don't recall rn how the unlimited transfers case was handled there (although actually it's not unlimited, but 14 :), I think we should unify this between the two – especially since the isochrones tab is already reusing the AdancedOptions component. And I personally think that a dropdown like over there or maybe a |
With #891 merged, I made the adjustments to show the dropdown to select |
Great, I'll take a look at the |
08405e6
to
36a5523
Compare
Nice, what do you think, what is less confusing? Always showing the actual technical upper limit of 14 transfers or showing some special label like "Unlimited" for that in the dropdown which is technically wrong? |
I think the concrete number is better. Maybe even configurable in the server because for small datasets a smaller number might improve performance without any disadvantage for the user. |
Ok but I think this is out of scope for this PR, since we have no straightforward way yet to pass this to the UI. |
This is how it looks:
Feel free to make changes, I am not very familiar with CSS/Tailwind