Refactor github integration and membership #438
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update testing and membership code in preparation for dropping support for older configurations.
This pull request is the first step of removing support for PySide and PyQt4 as well as python 2 support #413. It's focused on making it easier to generate common membership and updating the testing suite now that docker is no longer required.
I'm moving to tox because all of the required python and PySide/PyQt bindings are now available on pypi so we don't need to deal with compiling our own c code. I've also never really worked with docker but have used tox for many years. It also allows us to easily setup tests for specific combinations of qt binding and python version.
This pull request makes the following changes
This pull request prepares for but does not update
Next steps
This is my rough plan for the next steps required to actually drop Qt4 bindings support and older python. It's subject to change but should cover the main required changes.
requires-python = ">=3.7"so pip won't try to install the new code on unsupported older python versions.I think steps 2-5 should be individual commits in the final commit history. For development we may want to manage that with a branch other than master. I think the remaining steps are much less daunting than the changes required by this pull request. The second step is probably the most daunting task, as to figure out all the specific settings required takes a lot of research, but I've already done that research on several repos.