Skip to content

fix pivot selection #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2025
Merged

fix pivot selection #65

merged 3 commits into from
May 18, 2025

Conversation

muendlein
Copy link
Contributor

@muendlein muendlein commented May 17, 2025

Fixes #61
After some research the method of three seems to be sufficient enough to resolve the callstack issue.
Note: Performance testing shows no impact.

Copy link
Owner

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Should we also add the test case from #61 to the test suite?

@muendlein
Copy link
Contributor Author

Looks good to me! Should we also add the test case from #61 to the test suite?

Definitely! I just added the test for that.

@mourner
Copy link
Owner

mourner commented May 18, 2025

Can you also please fix the lint errors? I'll merge afterwards.

@muendlein
Copy link
Contributor Author

@mourner Should be fixed now.

@mourner mourner merged commit 1e87f40 into mourner:main May 18, 2025
1 check passed
@muendlein
Copy link
Contributor Author

@mourner Would it be possible to get a minor release which includes this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

finish() fails due to reaching max recursion depth in the sorting algorithm
2 participants