Setup with OpenCV 3.4.5 Debian package #5
Conversation
RoboticsYY
force-pushed
the
pr-setup_with_opencv_3.4.5_deb
branch
from
f508e96
to
8045511
Compare
moveit_calibration_plugins/handeye_calibration_target/test/handeye_target_test.cpp
Show resolved
Hide resolved
|
|
||
| git clone https://github.com/RoboticsYY/opencv_deb_install.git | ||
|
|
||
| find ./opencv_deb_install -name "OpenCV-3.4.5-x86_64-*.deb" | xargs sudo dpkg -i |
There was a problem hiding this comment.
This is clearly not a reasonable long-term solution. What's the plan there?
There was a problem hiding this comment.
I agree that this is not a perfect long-term solution, but to facilitate others to copy and test this tool. I have tested OpenCV 3.x and 4.1. Only 3.2 is not working well with Aruco marker detection. Actually we always avoid this version in any of our vision projects. Usually, I compile OpenCV from source. But this most likely will make CI timeout. I'm not sure if it's possible for Ubuntu to make a new version of OpenCV release with 18.04 or how far it would impact. One option in my head is to create PPA for this.
There was a problem hiding this comment.
Adding the PPA, if no compatible one already exists, would be a good simplification for users and should be preferred for CI over your custom binary git repo. Can you set this up and adapt this request?
The core issue is that the intuitive and default way to build this package (download and compile) apparently silently breaks tag detection and thus this package because it will use the standard system version.
So it's not enough to add a custom opencv version to the CI build, but the build should actually fail if you try to build with the broken version. You could add some error message referencing good versions of opencv and the ppa.
There was a problem hiding this comment.
I will create a PPA for the non-default version of OpenCV for this.
Great idea to add some error message or compilation limitation! I think I will add some check and message print in cmake files.
OpenCV 3.2, which is the default version on Ubuntu 18.04, is not working well for the ARUCO marker detection used in the hand-eye calibration. This PR provides a walk-around by installing OpenCV 3.4 through Debian packages.