-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set max cartesian end-effector speed in planning pipeline #277
base: master
Are you sure you want to change the base?
Conversation
I tested this successfully in the
Do you see a better pipeline planner demo where to set the max cartesian velocity? |
Instead of squeezing all features into the one demo, I would encourage you to just create a new demo, possibly something that resembles a simple welding trajectory. |
Makes sense, we will probably propose a welding demo, but rather in middle-long term. In shorter term I could propose to adapt the cartesian Demo to use the pipeline planner (Pilz and/or OMPL constrained planning) and set different cartesian velocities in there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In principle looks good to me. See the remark below.
I tried to add the explicit call in cartesian_path but I do not manage to get the velocity set in the cartesian demo. |
Enable trajectory post-processing in planning pipeline to set maximum cartesian end-effector speed.
Requires following to be merged:
How to use? Instead of
setProperty("max_velocity_scaling_factor", velocity);
, use:I will also implement it in the cartesian demo.
Solves #276