Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Bug 1218415 - [Messages][Tests] Add the "delete selected messages" integration test to "Conversation Edit Mode" suite #33384

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TheShadow29
Copy link

Done with part 1,2, ie going into edit mode, and selecting some messages. Part 3, 4 still remaining

@mozilla-autolander-deprecated
Copy link
Contributor

@@ -488,6 +488,18 @@ marionette('Conversation Panel Tests', function() {
'4 selected',
'Edit mode header should show correct number of messages'
);
test('User selects some messages ,deletes them',function(){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Don't keep commas in the test message, Space after comma please, Space after ) please

@martiansideofthemoon
Copy link
Contributor

@TheShadow29 , Good start 😄 I think you will have to fix the minor errors here. You can see a full list of errors detected by lint here :- https://tools.taskcluster.net/task-inspector/#MY2FDgDYR9-b5LLoFXP3_A/0
It would be a good idea to get your lint fixed so that you detect the errors while committing.

@martiansideofthemoon
Copy link
Contributor

You can learn how to run Gaia on your firefox : [1]
This will help you in your subsequent steps.
Follow the guide here to actually test what you code [2], that is run the marionette tests.

[1] - https://github.com/mozilla-b2g/gaia/tree/master/apps/sms#how-to-run-the-application-in-firefox
[2] - https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/Automated_testing/Gaia_integration_tests

@martiansideofthemoon
Copy link
Contributor

I suggest you to fix the above errors before trying out any of this. Also, have a look at how the mocha tests function. :-
http://dailyjs.com/2011/12/08/mocha/

Good Luck ! 😄

@cknowles-admin cknowles-admin added the ARCHIVED CLOSED at time of archiving label Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ARCHIVED CLOSED at time of archiving
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants