Skip to content

Commit

Permalink
Add FXIOS-10902 Firefox iOS send data deletion request when dau ping …
Browse files Browse the repository at this point in the history
…is toggled off (#24263)

* Add FXIOS-10902 Firefox iOS: Send data deletion request when DAU ping is toggled off

* Update data review link

* Add FXIOS-10902 Firefox iOS: Send data deletion request when DAU ping is toggled off

* Add links for data review

* Enable follows_collection_enabled=false type pings

* Swiftlint fix
  • Loading branch information
razvanlitianu authored Jan 27, 2025
1 parent 12120b3 commit 28c5ad7
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import Common
import UIKit
import Shared
import Glean

// MARK: - Settings Flow Delegate Protocol

Expand Down
3 changes: 3 additions & 0 deletions firefox-ios/Client/Telemetry/TelemetryWrapper.swift
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@ class TelemetryWrapper: TelemetryWrapperProtocol, FeatureFlaggable {
GleanMetrics.LegacyIds.clientId.set(uuid)
}

GleanMetrics.Pings.shared.usageDeletionRequest.setEnabled(enabled: true)
GleanMetrics.Pings.shared.onboardingOptOut.setEnabled(enabled: true)

// Set or generate profile id used for usage reporting
if sendUsageData {
if let uuidString = profile.prefs.stringForKey(PrefsKeys.Usage.profileId),
Expand Down
1 change: 1 addition & 0 deletions firefox-ios/Client/metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -752,6 +752,7 @@ usage:
expires: never
send_in_pings:
- usage-reporting
- usage-deletion-request

duration:
type: timing_distribution
Expand Down
24 changes: 24 additions & 0 deletions firefox-ios/Client/pings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -114,3 +114,27 @@ onboarding-opt-out:
metadata:
follows_collection_enabled: false
include_info_sections: false

usage-deletion-request:
description: |
This ping is submitted when a user opts out of sending usage
frequency of Firefox to Mozilla.
Sent in response to user action.
include_client_id: false
send_if_empty: true
bugs:
- https://mozilla-hub.atlassian.net/browse/FXIOS-10902
data_reviews:
- https://github.com/mozilla-mobile/firefox-ios/pull/24263
notification_emails:
- [email protected]
- [email protected]
- [email protected]
metadata:
follows_collection_enabled: false
include_info_sections: false
reasons:
set_upload_enabled: |
The ping was submitted between Glean init and Glean shutdown.
After init but before shutdown the upload of usage reporting data changed
from enabled to disabled.

0 comments on commit 28c5ad7

Please sign in to comment.