Last Viewed Folder Bookmarks Draft -- Not To Be Merged #24113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielDervishi
commented
Jan 13, 2025
Comment on lines
+229
to
+236
| CATransaction.begin() | ||
| CATransaction.setDisableActions(true) | ||
| self.navigationHandler?.start( | ||
| panelType: self.viewModel.selectedPanel ?? .bookmarks, | ||
| navigationController: panelNavigationController, | ||
| folderPath: path | ||
| ) | ||
| CATransaction.commit() |
There was a problem hiding this comment.
Responsible for disabling animations
DanielDervishi
commented
Jan 13, 2025
Comment on lines
+249
to
+266
| private func findPathToFolder(currentFolderGUID: String, | ||
| completion: @escaping (_: [String]?) -> Void) { | ||
| viewModel.profile.places.getBookmarksTree(rootGUID: BookmarkRoots.MobileFolderGUID, | ||
| recursive: true).uponQueue(.main) { result in | ||
| guard let maybeBookmarkTreeRoot = result.successValue, | ||
| let bookmarkTreeRoot = maybeBookmarkTreeRoot else { | ||
| completion(nil) | ||
| return | ||
| } | ||
| guard let path = self.findPathToFolderGivenTree(targetGUID: currentFolderGUID, | ||
| treeRootNode: bookmarkTreeRoot), | ||
| !path.isEmpty else { | ||
| completion(nil) | ||
| return | ||
| } | ||
| completion(path.map({ $0.guid })) | ||
| } | ||
| } |
There was a problem hiding this comment.
Method that runs asynchronously
|
This PR has been automatically marked as stale. Please leave any comment to keep this PR opened. It will be closed automatically if no further update occurs in the next 7 days. Thank you for your contributions! |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)