Bugfix FXIOS-10996 Fix app crashes in HistoryPanel due to duplicate Site identifiers #24116

ih-codes · 2025-01-13T21:58:19Z

📜 Tickets

💡 Description

This PR refactors the Site class and its inheriting classes to instead be a Site struct which synthesizes its Equatable and Hashable methods.

The purpose of this change is to clean up some old code, and ultimately ensure all Sites are unique and strictly Identifiable for diffing (as required on iOS 18 with the History Panel diffable data source).

This work should hopefully resolve crashes we are seeing on Sentry due to "duplicate" Sites, which is a regression on a past fix in this PR: #23494 (possibly caused by a backport related to the xcode 16 upgrade).

Main Changes:

The Site object was built as a class, with several types inheriting from it and adding additional functionality (suggested sites, sponsored tiles, pinned sites…). This felt a bit non-swifty. I tried making Site a protocol at first, but ran into issues with making other types that had any Site Equatable, as a concrete type was needed. So I opted to make an enum to identify each SiteType.
Because Site is inside the Storage target, it was necessary for me to move the associated types for suggested, sponsored, and pinned sites to Storage as well (as Storage cannot access Client).
Updated code in Client, Storage, and ClientTests for the refactor.
Refactored the Site implementation to use Codable instead of custom encode/decode methods (used for the WidgetExtension)
Refactored Site implementation to automatically synthesize Hashable and Equatable conformance vs. explicit implementations, which has caused bugs in the past due to the implementations not being symmetrical
Cleaned up some naming for clarity (e.g. "sponsored tiles" -> "sponsored sites").

Testing

Test cases are listed in the attached JIRA ticket. 🙏

📝 Checklist

You have to check all boxes before merging

Filled in the above information (tickets numbers and description of your work)
Updated the PR name to follow our PR naming guidelines
Wrote unit tests and/or ensured the tests suite is passing
When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
If needed, I updated documentation / comments for complex code and public methods
If needed, added a backport comment (example @Mergifyio backport release/v120)

…wift Int ID's larger than Int32 will crash.

… Improved existing tests and refactored force unwraps. Fixed misleading assert messages.

… protocol. This allows for automatic conformance to Equatable and Hashable, which should reduce programmer error and crashes related to diffable data sources.

…w field.

…e models.

…to use the new Site type.

…er, TabManagerMiddleware, ContextMenuHelper, SponsoredTileTelemetry, UnifiedAdsCallbackTelemetry, JumpBackInViewModel, HistoryPanelViewModel, and the WidgetExtension to use the new Site type.

…tension factory helper for creating a sponsored site using a Contile in the Client target,

…10996-refactor-history-panel-hashable-conformance # Conflicts: # firefox-ios/Storage/SQL/SQLiteHistoryFactories.swift

…ration from previous versions). Add documentation.

…IXMEs/TODOs.

…tor-history-panel-hashable-conformance # Conflicts: # firefox-ios/Client/Frontend/Home/Homepage Rebuild/TopSites/TopSitesManager.swift # firefox-ios/Client/Frontend/Home/Homepage Rebuild/TopSites/TopSitesMiddleware.swift # firefox-ios/Client/Frontend/Library/Bookmarks/BookmarksViewController.swift # firefox-ios/Storage/SQL/SQLiteHistoryFactories.swift # firefox-ios/firefox-ios-tests/Tests/StorageTests/TestSQLitePinnedSites.swift

mobiletest-ci-bot · 2025-01-13T22:10:07Z

	Warnings
⚠️	Pull Request size seems relatively large. If this Pull Request contains multiple changes, please split each into separate PR will helps faster, easier review. Consider using epic branches for work that would affect main.

	Messages
📖	Project coverage: 34.23%
📖	Edited 67 files
📖	Created 6 files

Client.app: Coverage: 32.38

File	Coverage
BrowserViewController.swift	3.47%	⚠️
ContextMenuConfiguration.swift	90.0%	✅
TabManagerMiddleware.swift	7.12%	⚠️
Profile.swift	22.21%	⚠️
SearchLoader.swift	0.0%	⚠️
BackForwardListViewController.swift	12.79%	⚠️
SearchHighlightItem.swift	0.0%	⚠️
HomepageContextMenuHelper.swift	3.72%	⚠️
PhotonActionSheetViewModel.swift	15.56%	⚠️
MainMenuActionHelper.swift	0.0%	⚠️
TopSitesProvider.swift	98.03%	✅
LegacyBookmarksPanel.swift	38.63%	⚠️
BookmarksViewController.swift	8.66%	⚠️
ContextMenuState.swift	2.82%	⚠️
TopSitesViewModel.swift	34.11%	⚠️
SearchViewController.swift	23.44%	⚠️
HistoryPanelViewModel.swift	84.46%	✅
HomepageContextMenuProtocol.swift	0.0%	⚠️
UnifiedAdsCallbackTelemetry.swift	77.94%	✅
TopSitesManager.swift	100.0%	✅
SearchTelemetry.swift	5.34%	⚠️
LegacyHomepageViewController.swift	36.42%	⚠️
TopSite.swift	38.98%	⚠️
BookmarksViewModel.swift	27.73%	⚠️
ReaderPanel.swift	29.13%	⚠️
TopSitesMiddleware.swift	100.0%	✅
SearchViewModel.swift	50.0%	⚠️
TopSitesWidgetManager.swift	0.0%	⚠️
TopSiteState.swift	30.36%	⚠️
SponsoredTileTelemetry.swift	83.33%	✅
JumpBackInViewModel.swift	38.36%	⚠️
RecentlyClosedTabsPanel.swift	7.32%	⚠️
GoogleTopSiteManager.swift	80.0%	✅
Site+createSponsoredSite.swift	100.0%	✅
TopSiteItemCell.swift	0.0%	⚠️
TopSiteCell.swift	0.0%	⚠️
PocketViewModel.swift	72.95%	✅
TopSitesDataAdaptor.swift	96.51%	✅

CredentialProvider.appex: Coverage: 21.41

File	Coverage
Profile.swift	22.21%	⚠️

NotificationService.appex: Coverage: 25.99

File	Coverage
Profile.swift	22.21%	⚠️

ShareTo.appex: Coverage: 31.44

File	Coverage
Profile.swift	22.21%	⚠️

WidgetKitExtension.appex: Coverage: 7.07

File	Coverage
TopSitesProvider.swift	0.0%	⚠️

libStorage.a: Coverage: 56.71

File	Coverage
RustPlaces.swift	80.88%	✅
SiteType.swift	66.67%	✅
SponsoredSiteInfo.swift	100.0%	✅
SQLiteHistoryFactories.swift	85.71%	✅
Site.swift	60.61%	✅
PageMetadata.swift	33.33%	⚠️
DefaultSuggestedSites.swift	90.91%	✅

Generated by 🚫 Danger Swift against 3f75507

firefox-ios/Client/Frontend/Browser/Search/SearchHighlightItem.swift

ih-codes · 2025-01-13T22:53:12Z

firefox-ios/Storage/Site.swift

-    // MARK: - Encode & Decode
-
-    public static func encode(with encoder: JSONEncoder, data: [Site]) throws -> Data {
-        let storage = data.map { site in
-            return site.storage
-        }
-        return try encoder.encode(storage)
-    }
-
-    public static func decode(from decoder: JSONDecoder, data: Data) throws -> [Site] {
-        let storage = try decoder.decode([Storage].self, from: data)
-        return storage.map {
-            return Site(from: $0)
-        }
-    }


This was the previous custom encoding logic

ih-codes · 2025-01-13T22:53:27Z

firefox-ios/Storage/Site.swift

-    // Created since to avoid making Sites Codable which involes making also PageMetadata and Visit Codable too
-    private struct Storage: Codable {
-        let resource: SiteResource?
-        let title: String
-        let id: Int?
-        let guid: String?
-        let url: String
-    }


This was used for the custom encoding logic and was removed

ih-codes · 2025-01-13T22:53:49Z

firefox-ios/Storage/Site.swift

-// MARK: - Hashable
-extension Site: Hashable {
-     public func hash(into hasher: inout Hasher) {
-         // The == operator below must match the same requirements as this method
-         hasher.combine(id)
-         hasher.combine(guid)
-         hasher.combine(title)
-         hasher.combine(url)
-         hasher.combine(faviconResource)
-     }
-
-     public static func == (lhs: Site, rhs: Site) -> Bool {
-         // The hash method above must match the same requirements as this operator
-         return lhs.id == rhs.id
-         && lhs.guid == rhs.guid
-         && lhs.title == rhs.title
-         && lhs.url == rhs.url
-         && lhs.faviconResource == rhs.faviconResource
-     }
- }


These were the removed methods we want to auto synthesize to hopefully help with the crash

Cramsden

Some thoughts!

firefox-ios/Client/Frontend/Home/Homepage Rebuild/TopSites/TopSitesManager.swift

Cramsden · 2025-01-14T16:23:45Z

firefox-ios/Client/Frontend/Home/HomepageContextMenuHelper.swift

-            self.viewModel.profile.places.deleteBookmarksWithURL(url: site.url) >>== {
-                site.setBookmarked(false)
-            }
+            self.viewModel.profile.places.deleteBookmarksWithURL(url: site.url) >>== {}


This syntactical sugar is beyond me but do we still need the deferment chaos here?

😅 Looks like these are the options:
_ = self.viewModel.profile.places.deleteBookmarksWithURL(url: site.url)
and
self.viewModel.profile.places.deleteBookmarksWithURL(url: site.url) >>== {}

I'll go with the first one since it's slightly shorter / more obvious... and going to add a comment too.

Cramsden · 2025-01-14T16:56:38Z

firefox-ios/Client/Frontend/Home/TopSites/Cell/TopSiteItemCell.swift

-            // Return our bundled G icon for all of the Google Suite.
-            // Parse example: "https://drive.google.com/drive/home" > "drive.google.com" > "google"
-            imageResource = GoogleTopSiteManager.Constants.faviconResource
+        switch topSite.site.type {


Nit: I kinda wish this var was topSiteState instead of topsite or we could put a var on TopSiteState:

var type: SiteType { return site.type }

Good idea, will add that!

Cramsden · 2025-01-14T17:00:14Z

firefox-ios/Client/Frontend/Home/TopSites/Cell/TopSiteItemCell.swift

+        case .pinnedSite, .suggestedSite:
+            imageResource = topSite.site.faviconResource
+        default:
+            if let siteURL = URL(string: siteURLString),


Does this piece actually work? Isn't the google site a pinned site?

This was to override ALL google favicons with our embedded google image (since google has notoriously low quality favicons for some reason)... The pinned google tile should have a faviconResource already attached. (Actually, funny story, it didn't, but thanks to this comment I double checked and fixed it at the call site in GoogleTopSiteManager.swift 😂 )

firefox-ios/Client/Frontend/Home/TopSites/DataManagement/TopSitesDataAdaptor.swift

...os/Client/Frontend/Home/TopSites/DataManagement/UnifiedAds/UnifiedAdsCallbackTelemetry.swift

Cramsden · 2025-01-15T18:20:39Z

firefox-ios/Storage/DefaultSuggestedSites.swift

+            if let domainMap = DefaultSuggestedSites.urlMap[site.url],
+               let localizedURL = domainMap[locale.identifier] {
+                return Site(copiedFromSite: site, withLocalizedURLString: localizedURL)


Does this need to be a suggested Site instead of the default initializer

Good call out, since this looks wrong at a glance. But I think we're ok here. This copies the current Site (so .suggestedSite remains the same) and just updates the (nonmutable) url property on Site... a little hokey but I really didn't want url to be a var on the struct.

Cramsden · 2025-01-15T18:22:59Z

firefox-ios/Storage/Rust/RustPlaces.swift

@@ -722,7 +722,7 @@ extension RustPlaces {
                }
                // Note: FXIOS-10740 Necessary to have unique Site ID iOS 18 HistoryPanel crash with diffable data sources
                let hashValue = "\(info.url)_\(info.timestamp)".hashValue
-                let site = Site(id: hashValue, url: info.url, title: title)
+                var site = Site(id: hashValue, url: info.url, title: title, type: .basic)


Sometimes we are using the default initializer and sometimes we are using the static funcs to initialize... should we just pick one and make the others private?

Hmmm yes I see what you mean...

This is one of the rare places we explicitly want to define the ID rather than auto generate one, which is why it's like this...

I'm going to make the default init private, and we can add an optional first ID param to the createBasicSite factory method.

Cramsden · 2025-01-15T18:28:22Z

firefox-ios/Storage/Sites/Site.swift

+            return URL(string: url, invalidCharacters: false) ?? URL(string: "about:blank")!
+        default:
+            return URL(string: url, invalidCharacters: false)?.domainURL ?? URL(string: "about:blank")!


Is this preferred to just having an optional url? I just worry if this is nil then the issue is obfuscated.

I honestly have no idea. Everyone wants to remove the force unwraps but I just copied what was already in the app and moved it here... 😬 I'm open to suggestions. 😆

hmmm I guess I would alternatively just have the optional value returned here and then we could unwrap it somewhere else more meaningful? But also this is fine for now because I imagine that is a bigger change.

Cramsden · 2025-01-15T18:34:41Z

firefox-ios/Storage/Sites/SiteType.swift

+    public var isPinnedSite: Bool {
+        switch self {
+        case .pinnedSite:
+            return true
+        default:
+            return false
+        }
+    }
+
+    public var isSponsoredSite: Bool {
+        switch self {
+        case .sponsoredSite:
+            return true
+        default:
+            return false
+        }
+    }
+
+    public var isSuggestedSite: Bool {
+        switch self {
+        case .suggestedSite:
+            return true
+        default:


This might be overkill but it might be nice to have these helpers in Site so that instead of accessing site.type.isSuggestedSite we could just access site.isSuggestedSite

Good idea, I'll add that! 👍

mergify · 2025-01-15T18:47:16Z

This pull request has conflicts when rebasing. Could you fix it @ih-codes? 🙏

…nsored sites.

…s to create sites.

…tor-history-panel-hashable-conformance # Conflicts: # firefox-ios/Storage/DefaultSuggestedSites.swift

ih-codes

Ok, made the requested changes, ready for another look! cc @Cramsden

ih-codes · 2025-01-16T21:03:59Z

firefox-ios/Client/Frontend/Home/TopSites/Cell/TopSiteItemCell.swift

-            // Return our bundled G icon for all of the Google Suite.
-            // Parse example: "https://drive.google.com/drive/home" > "drive.google.com" > "google"
-            imageResource = GoogleTopSiteManager.Constants.faviconResource
+        switch topSite.site.type {


Good idea, will add that!

ih-codes · 2025-01-16T21:04:17Z

firefox-ios/Client/Frontend/Home/HomepageContextMenuHelper.swift

-            self.viewModel.profile.places.deleteBookmarksWithURL(url: site.url) >>== {
-                site.setBookmarked(false)
-            }
+            self.viewModel.profile.places.deleteBookmarksWithURL(url: site.url) >>== {}


😅 Looks like these are the options:
_ = self.viewModel.profile.places.deleteBookmarksWithURL(url: site.url)
and
self.viewModel.profile.places.deleteBookmarksWithURL(url: site.url) >>== {}

I'll go with the first one since it's slightly shorter / more obvious... and going to add a comment too.

...os/Client/Frontend/Home/TopSites/DataManagement/UnifiedAds/UnifiedAdsCallbackTelemetry.swift

ih-codes · 2025-01-16T22:55:15Z

firefox-ios/Storage/DefaultSuggestedSites.swift

+            if let domainMap = DefaultSuggestedSites.urlMap[site.url],
+               let localizedURL = domainMap[locale.identifier] {
+                return Site(copiedFromSite: site, withLocalizedURLString: localizedURL)


Good call out, since this looks wrong at a glance. But I think we're ok here. This copies the current Site (so .suggestedSite remains the same) and just updates the (nonmutable) url property on Site... a little hokey but I really didn't want url to be a var on the struct.

ih-codes · 2025-01-16T22:56:14Z

firefox-ios/Storage/Sites/Site.swift

+            return URL(string: url, invalidCharacters: false) ?? URL(string: "about:blank")!
+        default:
+            return URL(string: url, invalidCharacters: false)?.domainURL ?? URL(string: "about:blank")!


I honestly have no idea. Everyone wants to remove the force unwraps but I just copied what was already in the app and moved it here... 😬 I'm open to suggestions. 😆

ih-codes · 2025-01-16T22:57:37Z

firefox-ios/Storage/Sites/SiteType.swift

+    public var isPinnedSite: Bool {
+        switch self {
+        case .pinnedSite:
+            return true
+        default:
+            return false
+        }
+    }
+
+    public var isSponsoredSite: Bool {
+        switch self {
+        case .sponsoredSite:
+            return true
+        default:
+            return false
+        }
+    }
+
+    public var isSuggestedSite: Bool {
+        switch self {
+        case .suggestedSite:
+            return true
+        default:


Good idea, I'll add that! 👍

firefox-ios/Client/Frontend/Home/TopSites/DataManagement/TopSitesDataAdaptor.swift

ih-codes · 2025-01-16T23:18:21Z

firefox-ios/Storage/Rust/RustPlaces.swift

@@ -722,7 +722,7 @@ extension RustPlaces {
                }
                // Note: FXIOS-10740 Necessary to have unique Site ID iOS 18 HistoryPanel crash with diffable data sources
                let hashValue = "\(info.url)_\(info.timestamp)".hashValue
-                let site = Site(id: hashValue, url: info.url, title: title)
+                var site = Site(id: hashValue, url: info.url, title: title, type: .basic)


Hmmm yes I see what you mean...

This is one of the rare places we explicitly want to define the ID rather than auto generate one, which is why it's like this...

I'm going to make the default init private, and we can add an optional first ID param to the createBasicSite factory method.

ih-codes · 2025-01-17T16:36:44Z

firefox-ios/Client/Frontend/Home/TopSites/Cell/TopSiteItemCell.swift

+        case .pinnedSite, .suggestedSite:
+            imageResource = topSite.site.faviconResource
+        default:
+            if let siteURL = URL(string: siteURLString),


This was to override ALL google favicons with our embedded google image (since google has notoriously low quality favicons for some reason)... The pinned google tile should have a faviconResource already attached. (Actually, funny story, it didn't, but thanks to this comment I double checked and fixed it at the call site in GoogleTopSiteManager.swift 😂 )

firefox-ios/Client/Frontend/Home/Homepage Rebuild/TopSites/TopSitesManager.swift

ih-codes · 2025-01-21T23:19:21Z

@Cramsden Argh, looks like some more merge conflicts on this branch -- will fix tomorrow morning. Just FYI if you re-review tonight.

mergify · 2025-01-22T02:52:43Z

This pull request has conflicts when rebasing. Could you fix it @ih-codes? 🙏

Cramsden

I think there are some merge conflicts that need to be resolved but the additional changes look good to me!

ih-codes added 26 commits January 9, 2025 13:40

FXIOS-11014 - Remove deprecated Site GUID from SQL Lite Database

7dea3c0

FXIOS-11015 - Bugfix - Sites inserted into the SQLite database with S…

775496f

…wift Int ID's larger than Int32 will crash.

Add unit test for int64 size Site IDs to TestSQLitePinnedSites.swift.…

4fadb16

… Improved existing tests and refactored force unwraps. Fixed misleading assert messages.

Cleanup.

f239bb5

Refactor the Site class to be a BasicSite struct adhering to the Site…

125b057

… protocol. This allows for automatic conformance to Equatable and Hashable, which should reduce programmer error and crashes related to diffable data sources.

Update SQLLite factories for new Site type. Remove deprecated GUID ro…

0846222

…w field.

Move all Site related files to Storage > Sites.

4c2525f

Rough in new Site struct and related types enum and its associatedTyp…

e3bbd78

…e models.

Adjust file naming for new model naming.

e50363c

Remove site info model types from Client membership.

5cee67e

Migrate DefaultSuggestedSites, SQLLite related files, and RustPlaces …

70f26c9

…to use the new Site type.

Migrate MainMenuActionHelper, SearchHighlightItem, SearchViewControll…

c7fd99c

…er, TabManagerMiddleware, ContextMenuHelper, SponsoredTileTelemetry, UnifiedAdsCallbackTelemetry, JumpBackInViewModel, HistoryPanelViewModel, and the WidgetExtension to use the new Site type.

Migrate TopSites related code to use the new Site type.

ef6ed09

More Site cleanup.

bee92de

Fix unit tests and other compilation errors with Site updates. Add ex…

5597bf5

…tension factory helper for creating a sponsored site using a Contile in the Client target,

Merge branch 'ih/FXIOS-11015-fix-sqlite-int64-storage' into ih/FXIOS-…

c031774

…10996-refactor-history-panel-hashable-conformance # Conflicts: # firefox-ios/Storage/SQL/SQLiteHistoryFactories.swift

Amend fix merge for new Site with forced unique non-nil IDs.

b8883fc

Fix widget extension by making encode/decode of IDs optional (for mig…

1bcfbea

…ration from previous versions). Add documentation.

Rename "suggested" google site to "pinned" site data.

1370f0e

Unit test fixes for google pinned site rename.

3738596

Refactoring and cleanup. Added documentation. Renaming. Cleaning up F…

fbf7a76

…IXMEs/TODOs.

Swiftlint fixes.

8e44370

Simplify some logic.

64c46c6

Bugfix from refactor.

d8076b1

Move SiteType to its own file.

477fc9f

ih-codes requested a review from Cramsden January 13, 2025 21:58

ih-codes requested a review from a team as a code owner January 13, 2025 21:58

Remove unused placeholder "google guid."

dafabd9

Cleanup. Revert a doc change.

3d8a49d

ih-codes commented Jan 13, 2025

View reviewed changes

Cramsden reviewed Jan 15, 2025

View reviewed changes

ih-codes added 8 commits January 16, 2025 15:24

Add type helper to TopSiteState.

06ccf62

Be more explicit about ignoring places deferred closure.

3159687

Add documentation to be more explicit about sending telemetry for spo…

a2db44c

…nsored sites.

Add some Site helpers for type. Use to simplify some type checks.

7208770

Make Site default inits private so we consistently use factory method…

48800cc

…s to create sites.

Simplify countPinnedSites.

04d95da

Fix passing favicon resource to the google pinned tile.

8641fed

Merge remote-tracking branch 'mozilla/main' into ih/FXIOS-10996-refac…

6145d2e

…tor-history-panel-hashable-conformance # Conflicts: # firefox-ios/Storage/DefaultSuggestedSites.swift

ih-codes had a problem deploying to github-pages January 17, 2025 17:20 — with GitHub Actions Failure

ih-codes commented Jan 17, 2025

View reviewed changes

ih-codes requested a review from Cramsden January 17, 2025 17:21

Fix unit tests compiling.

3f75507

Cramsden approved these changes Jan 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bugfix FXIOS-10996 Fix app crashes in HistoryPanel due to duplicate Site identifiers #24116

Bugfix FXIOS-10996 Fix app crashes in HistoryPanel due to duplicate Site identifiers #24116

ih-codes commented Jan 13, 2025

mobiletest-ci-bot commented Jan 13, 2025 •

edited

Loading

ih-codes Jan 13, 2025

ih-codes Jan 13, 2025

ih-codes Jan 13, 2025

Cramsden left a comment

Cramsden Jan 14, 2025

ih-codes Jan 16, 2025

Cramsden Jan 14, 2025

ih-codes Jan 16, 2025

Cramsden Jan 14, 2025

ih-codes Jan 17, 2025

Cramsden Jan 15, 2025

ih-codes Jan 16, 2025

Cramsden Jan 15, 2025

ih-codes Jan 16, 2025

Cramsden Jan 15, 2025

ih-codes Jan 16, 2025

Cramsden Jan 22, 2025

Cramsden Jan 15, 2025

ih-codes Jan 16, 2025

mergify bot commented Jan 15, 2025

ih-codes left a comment

ih-codes Jan 16, 2025

ih-codes Jan 16, 2025

ih-codes Jan 16, 2025

ih-codes Jan 16, 2025

ih-codes Jan 16, 2025

ih-codes Jan 16, 2025

ih-codes Jan 17, 2025

ih-codes commented Jan 21, 2025

mergify bot commented Jan 22, 2025

Cramsden left a comment

Bugfix FXIOS-10996 Fix app crashes in HistoryPanel due to duplicate Site identifiers #24116

Are you sure you want to change the base?

Bugfix FXIOS-10996 Fix app crashes in HistoryPanel due to duplicate Site identifiers #24116

Conversation

ih-codes commented Jan 13, 2025

📜 Tickets

💡 Description

Main Changes:

Testing

📝 Checklist

mobiletest-ci-bot commented Jan 13, 2025 • edited Loading

Client.app: Coverage: 32.38

CredentialProvider.appex: Coverage: 21.41

NotificationService.appex: Coverage: 25.99

ShareTo.appex: Coverage: 31.44

WidgetKitExtension.appex: Coverage: 7.07

libStorage.a: Coverage: 56.71

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Cramsden left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mergify bot commented Jan 15, 2025

ih-codes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ih-codes commented Jan 21, 2025

mergify bot commented Jan 22, 2025

Cramsden left a comment

Choose a reason for hiding this comment

mobiletest-ci-bot commented Jan 13, 2025 •

edited

Loading