Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FXIOS-11025 [Glean improvements] Refactor HomepageTelemetry to Use Glean Wrapper for Improved Testability πŸš€ #24121

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Fix: Remove unneeded overridden functions in HomepageTelemetryTests

a2c0832
Select commit
Loading
Failed to load commit list.
Open

Refactor FXIOS-11025 [Glean improvements] Refactor HomepageTelemetry to Use Glean Wrapper for Improved Testability πŸš€ #24121

Fix: Remove unneeded overridden functions in HomepageTelemetryTests
a2c0832
Select commit
Loading
Failed to load commit list.
Mergify / Summary succeeded Jan 21, 2025 in 1s

3 potential rules

Rule: Resolve conflict (comment)

  • conflict

Rule: Needs landing - Rebase (queue)

  • check-success=Bitrise
  • label=Needs Landing
  • any of: [πŸ”€ queue conditions]
    • all of: [πŸ“Œ queue conditions of queue rebase-queue]
      • check-success=Bitrise
      • any of: [πŸ›‘ GitHub branch protection]
        • check-neutral = Bitrise
        • check-skipped = Bitrise
        • check-success = Bitrise
      • #approved-reviews-by >= 1 [πŸ›‘ GitHub branch protection]
      • #changes-requested-reviews-by = 0 [πŸ›‘ GitHub branch protection]
      • branch-protection-review-decision = APPROVED [πŸ›‘ GitHub branch protection]
  • #approved-reviews-by>=1
  • -closed [πŸ“Œ queue requirement]
  • -conflict [πŸ“Œ queue requirement]
  • -draft
  • -draft [πŸ“Œ queue requirement]
  • label!=Do Not Merge ⛔️
  • any of: [πŸ“Œ queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

Rule: Needs landing - Squash (queue)

  • check-success=Bitrise
  • label=Needs Landing (Squash)
  • any of: [πŸ”€ queue conditions]
    • all of: [πŸ“Œ queue conditions of queue squash-queue]
      • check-success=Bitrise
      • any of: [πŸ›‘ GitHub branch protection]
        • check-neutral = Bitrise
        • check-skipped = Bitrise
        • check-success = Bitrise
      • #approved-reviews-by >= 1 [πŸ›‘ GitHub branch protection]
      • #changes-requested-reviews-by = 0 [πŸ›‘ GitHub branch protection]
      • branch-protection-review-decision = APPROVED [πŸ›‘ GitHub branch protection]
  • #approved-reviews-by>=1
  • -closed [πŸ“Œ queue requirement]
  • -conflict [πŸ“Œ queue requirement]
  • -draft
  • -draft [πŸ“Œ queue requirement]
  • label!=Do Not Merge ⛔️
  • any of: [πŸ“Œ queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

πŸ’–Β Β Mergify is proud to provide this service for free to open source projects.

πŸš€Β Β You can help us by becoming a sponsor!


6 not applicable rules

Rule: Bitrise update - Auto Merge (queue)

  • -files~=^(?!bitrise.yml).+$
  • author=github-actions[bot]
  • check-success=Bitrise
  • files=bitrise.yml
  • head=update-br-new-xcode-version
  • any of: [πŸ”€ queue conditions]
    • all of: [πŸ“Œ queue conditions of queue rebase-queue]
      • check-success=Bitrise
      • any of: [πŸ›‘ GitHub branch protection]
        • check-neutral = Bitrise
        • check-skipped = Bitrise
        • check-success = Bitrise
      • #approved-reviews-by >= 1 [πŸ›‘ GitHub branch protection]
      • #changes-requested-reviews-by = 0 [πŸ›‘ GitHub branch protection]
      • branch-protection-review-decision = APPROVED [πŸ›‘ GitHub branch protection]
  • -closed [πŸ“Œ queue requirement]
  • -conflict [πŸ“Œ queue requirement]
  • -draft [πŸ“Œ queue requirement]
  • any of: [πŸ“Œ queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

Rule: Bitrise update - Auto Merge (review)

  • -files~=^(?!bitrise.yml).+$
  • author=github-actions[bot]
  • check-success=Bitrise
  • files=bitrise.yml
  • head=update-br-new-xcode-version

Rule: Rust Component Upgrade - Auto Merge (queue)

  • author=github-actions[bot]
  • check-success=Bitrise
  • files=Client.xcodeproj/project.pbxproj
  • files=Client.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
  • any of: [πŸ”€ queue conditions]
    • all of: [πŸ“Œ queue conditions of queue rebase-queue]
      • check-success=Bitrise
      • any of: [πŸ›‘ GitHub branch protection]
        • check-neutral = Bitrise
        • check-skipped = Bitrise
        • check-success = Bitrise
      • #approved-reviews-by >= 1 [πŸ›‘ GitHub branch protection]
      • #changes-requested-reviews-by = 0 [πŸ›‘ GitHub branch protection]
      • branch-protection-review-decision = APPROVED [πŸ›‘ GitHub branch protection]
  • -closed [πŸ“Œ queue requirement]
  • -conflict [πŸ“Œ queue requirement]
  • -draft [πŸ“Œ queue requirement]
  • any of: [πŸ“Œ queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

Rule: Rust Component Upgrade - Auto Merge (review)

  • author=github-actions[bot]
  • check-success=Bitrise
  • files=Client.xcodeproj/project.pbxproj
  • files=Client.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

Rule: L10N - Auto Merge (queue)

  • -files~=^(?!^.+\.strings).+$
  • author=github-actions[bot]
  • check-success=Bitrise
  • files~=^.+\.strings$
  • any of: [πŸ”€ queue conditions]
    • all of: [πŸ“Œ queue conditions of queue rebase-queue]
      • check-success=Bitrise
      • any of: [πŸ›‘ GitHub branch protection]
        • check-neutral = Bitrise
        • check-skipped = Bitrise
        • check-success = Bitrise
      • #approved-reviews-by >= 1 [πŸ›‘ GitHub branch protection]
      • #changes-requested-reviews-by = 0 [πŸ›‘ GitHub branch protection]
      • branch-protection-review-decision = APPROVED [πŸ›‘ GitHub branch protection]
  • -closed [πŸ“Œ queue requirement]
  • -conflict [πŸ“Œ queue requirement]
  • -draft [πŸ“Œ queue requirement]
  • any of: [πŸ“Œ queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

Rule: L10N - Auto Merge (review)

  • -files~=^(?!^.+\.strings).+$
  • author=github-actions[bot]
  • check-success=Bitrise
  • files~=^.+\.strings$
Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com