Skip to content

Add FXIOS-10138 [Menu]⁃ Investigate Print option for Save Sub Menu#24149

Merged
dicarobinho merged 1 commit intomainfrom
afarcasanu/fxios_10138_22211_print_tools_option
Jan 23, 2025
Merged

Add FXIOS-10138 [Menu]⁃ Investigate Print option for Save Sub Menu#24149
dicarobinho merged 1 commit intomainfrom
afarcasanu/fxios_10138_22211_print_tools_option

Conversation

@dicarobinho
Copy link
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

Added a new option (Print) under the Tools submenu

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@dicarobinho dicarobinho marked this pull request as ready for review January 15, 2025 11:34
@dicarobinho dicarobinho requested a review from a team as a code owner January 15, 2025 11:34
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 34.2%
📖 Edited 6 files
📖 Created 0 files

Client.app: Coverage: 32.39

File Coverage
MainMenuMiddleware.swift 38.82% ⚠️
BrowserCoordinator.swift 73.17%
MenuNavigationDestination.swift 100.0%
MainMenuCoordinator.swift 87.58%
MainMenuConfigurationUtility.swift 26.39% ⚠️

Generated by 🚫 Danger Swift against 3b03dde

Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing here for me to review, telemetry implementation doesn't typically require a re-review and adding this still adheres to the data-collection request as written. 👋

@dicarobinho dicarobinho merged commit a5e6306 into main Jan 23, 2025
10 checks passed
@dicarobinho dicarobinho deleted the afarcasanu/fxios_10138_22211_print_tools_option branch January 23, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants