Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FXIOS-10138 [Menu]⁃ Investigate Print option for Save Sub Menu #24149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dicarobinho
Copy link
Collaborator

πŸ“œ Tickets

Jira ticket
Github issue

πŸ’‘ Description

Added a new option (Print) under the Tools submenu

πŸ“ Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@dicarobinho dicarobinho marked this pull request as ready for review January 15, 2025 11:34
@dicarobinho dicarobinho requested a review from a team as a code owner January 15, 2025 11:34
@mobiletest-ci-bot
Copy link

Messages
πŸ“– Project coverage: 34.2%
πŸ“– Edited 6 files
πŸ“– Created 0 files

Client.app: Coverage: 32.39

File Coverage
MainMenuMiddleware.swift 38.82% ⚠️
BrowserCoordinator.swift 73.17% βœ…
MenuNavigationDestination.swift 100.0% βœ…
MainMenuCoordinator.swift 87.58% βœ…
MainMenuConfigurationUtility.swift 26.39% ⚠️

Generated by 🚫 Danger Swift against 3b03dde

Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing here for me to review, telemetry implementation doesn't typically require a re-review and adding this still adheres to the data-collection request as written. πŸ‘‹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants