-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FXIOS-10139 [Menu] β Investigate Save as PDF option for Save Sub Menu #24150
Open
dicarobinho
wants to merge
4
commits into
main
Choose a base branch
from
afarcasanu/fxios_10139_22212_saveaspdf_save_option
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add FXIOS-10139 [Menu] β Investigate Save as PDF option for Save Sub Menu #24150
dicarobinho
wants to merge
4
commits into
main
from
afarcasanu/fxios_10139_22212_saveaspdf_save_option
+86
β0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client.app: Coverage: 32.35
Generated by π« Danger Swift against f7c1456 |
travis79
reviewed
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing here for me to review, telemetry implementation doesn't typically require a re-review and adding this still adheres to the data-collection request as written. π
Yohanna Shokai
β¦On Thu, Jan 16, 2025 at 7:06β―AM Travis Long ***@***.***> wrote:
***@***.**** commented on this pull request.
Nothing here for me to review, telemetry implementation doesn't typically
require a re-review and adding this still adheres to the data-collection
request as written. π
β
Reply to this email directly, view it on GitHub
<#24150 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMPJEQXCRXNXJGP5EF3EAV32K6VGJAVCNFSM6AAAAABVHDGGJ2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNJWGAYTGNJWG4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Hi Travis,
Thanks for your comment. I understand that there is nothing for you to
review in this pull request since it is related to telemetry
implementation. I agree that adding the Save as PDF option still adheres to
the data-collection request as written.
If you have any further questions or concerns, please let me know.
Best regards,
Yohanna
|
dicarobinho
had a problem deploying
to
github-pages
January 22, 2025 07:48 — with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Tickets
Jira ticket
Github issue
π‘ Description
Added a new option under the Save submenu (Print as PDF)
π Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120
)