Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FXIOS-10937] Bugzilla #1933079 #24194

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[FXIOS-10937] Bugzilla #1933079 #24194

wants to merge 1 commit into from
+6 −0

Conversation

mattreaganmozilla
Copy link
Collaborator

📜 Tickets

Jira ticket
Bugzilla

💡 Description

See also: #24165

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@mattreaganmozilla
Copy link
Collaborator Author

Note: there is quite a bit of context for this ticket. LMK if any reviewers wish to sync up to discuss further. Thank you (cc @lmarceau)

@mattreaganmozilla mattreaganmozilla marked this pull request as ready for review January 21, 2025 16:57
@mattreaganmozilla mattreaganmozilla requested a review from a team as a code owner January 21, 2025 16:57
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 34.17%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 32.38

File Coverage
BrowserViewController.swift 3.46% ⚠️

Generated by 🚫 Danger Swift against 9484f92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmarceau lmarceau Awaiting requested review from lmarceau

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattreaganmozilla @mobiletest-ci-bot